Giter Club home page Giter Club logo

Comments (2)

migduroli avatar migduroli commented on May 24, 2024 1

@perdy, I also think we should close this PR. I'm afraid the current state of the project is no longer compatible with these changes. Indeed, this might've been resolved indirectly via other changes that have come up over the last few months for the release of v1.0.0. We should consider to close the issue, and PR, and re-consider whether this is still needed in the framework over a discussion prior to any work. This way we can ensure we are note duplicating efforts. And, for sure, thanks a lot to @mvanderlee for this and any future suggestions :)

from flama.

perdy avatar perdy commented on May 24, 2024

The same I told in #37 could be applied here. I don't see a huge gain in making the dependency injection works with BackgroundTasks because those aren't reflected in API schema. I understand it helps with coding under an IDE but as background tasks are called from endpoints and those already have dependency injection it could be done by relaying the dependencies.

My thoughts are the same here, maybe a plugin is the way to go for this kind of enhanced functionality.

from flama.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.