Giter Club home page Giter Club logo

Comments (5)

VonHeikemen avatar VonHeikemen commented on May 25, 2024 1

Might be worth creating an issue in friendly-snippet, so they can add a proper snippet for the else statement.

I'll mention this in the "advance usage" page, how to change the snippet collection.


By the way, you don't have to configure sumneko_lua if you use lsp.nvim_workspace(). You can modify the library argument like this.

lsp.nvim_workspace({
  library = vim.api.nvim_get_runtime_file('', true)
})

from lsp-zero.nvim.

technicalpickles avatar technicalpickles commented on May 25, 2024

Here is the friendly snippet for it: https://github.com/rafamadriz/friendly-snippets/blob/main/snippets/ruby.json#L84-L93

	"if else": {
		"prefix": "if else",
		"body": [
			"if ${1:test}",
			"\t$0",
			"else",
			"\t",
			"end"
		]
	},

The prefix gets translated to trig: https://github.com/L3MON4D3/LuaSnip/blob/09ce9a70bd787d4ce188f2de1390f656f119347c/lua/luasnip/loaders/from_vscode.lua#L35-L52

I haven't been able to trace where trig gets used when deciding if something is expandable yet.

from lsp-zero.nvim.

VonHeikemen avatar VonHeikemen commented on May 25, 2024

The first item in the completion list is always preselected, that's why pressing Enter confirms the snippet. If you want to disable this behaviour add this in your nvim-cmp config.

  preselect = 'none',
  completion = {
    completeopt = 'menu,menuone,noinsert,noselect'
  },

from lsp-zero.nvim.

technicalpickles avatar technicalpickles commented on May 25, 2024

I think my issue is more that else is completing to a snippet named 'if else'. Did some looking around, and it seems that other snippet plugins don't use that convention. Compare to vim-snippets which is a snipmate-style, which uses ife for if else:

CleanShot 2022-11-22 at 12 21 30

Given that, I think it's an issue with luasnip's matching, or friendly-snippets 'if else' prefix.

For anyone curious how to switch to this:

-- in `packer` block
	-- lsp, linters, formatters, etc
	use({
		"VonHeikemen/lsp-zero.nvim",
		requires = {
			-- LSP Support
			{ "neovim/nvim-lspconfig" },
			{ "williamboman/mason.nvim" },
			{ "williamboman/mason-lspconfig.nvim" },

			-- Autocompletion
			{ "hrsh7th/nvim-cmp" },
			{ "hrsh7th/cmp-buffer" },
			{ "hrsh7th/cmp-path" },
			{ "saadparwaiz1/cmp_luasnip" },
			{ "hrsh7th/cmp-nvim-lsp" },
			{ "hrsh7th/cmp-nvim-lua" },

			-- Snippets
			{ "L3MON4D3/LuaSnip" },
			-- instead of { "rafamadriz/friendly-snippets" },
			{"honza/vim-snippets"},
		},
	})

-- where lsp-zero is configured:
require("luasnip.loaders.from_snipmate").lazy_load()

from lsp-zero.nvim.

technicalpickles avatar technicalpickles commented on May 25, 2024

I filed it over at rafamadriz/friendly-snippets#209 so can close this now.

Thank @VonHeikemen for the tip re nvim workspace!

from lsp-zero.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.