builtin httpd not working when enabled via cmake define about vzlogger HOT 11 CLOSED

can you be a bit more specific?
microhttpd should be enabled automatically if it's installed, at least that is the case for me.
actually is is not even optional and the build will fail if it's not available.

what does the output of 'cmake' say?
should say something like:

        ***** Configuration parameters ***** 
             microhttpd: -L/usr/lib/arm-linux-gnueabihf/libmicrohttpd.a;-lrt -I/usr/include

what makes you assume it's disabled?

from vzlogger.

what makes you assume it's disabled?

ML discussion: nothing listening on the local port...

from vzlogger.

then this is unrelated to cmake...

from vzlogger.

Recompiled everything, forcing uhttpd to be included as follows in src/vzlogger.cpp:

#define LOCAL_SUPPORT 1

Now uhttpd indeed is included and working.

from vzlogger.

Now uhttpd indeed is included and working.

I still don't get how the cmakeoption is supposed to work and why it doesn't. Or are you saying if the #define is in then cmake can change the behaviour?

from vzlogger.

curious...
the cmake configuration considers it a fatal error if sml or microhttpd are not available,
while it's actually supported to build without them...
will investigate.

from vzlogger.

On 2014-12-23 14:59 , andig wrote:

Now uhttpd indeed is included and working.

I still don't get how the |cmake|option is supposed to work and why it
doesn't.

Same here. CMake, IMake, etc. have always been "black magic" to me... ;-)

Or are you saying if the |#define| is in then |cmake| can change the
behaviour?

No, I'm just saying that by hard-coding the #define uhttpd will be
actually included (not surprising).

I don't think that if you hard-code the #define into the source code
/any/ CMake setting could "override" this...

from vzlogger.

so, the correct bug-report is:
~/vzlogger# rm config.hpp
~/vzlogger# cmake -DENABLE_LOCAL=on .
~/vzlogger_r00t# grep LOCAL config.hpp
/* #undef LOCAL_SUPPORT */

from vzlogger.

[/vzlogger_r00t]$ rm config.hpp
[/vzlogger_r00t]$ cmake -DENABLE_LOCAL=on .
[/vzlogger_r00t]$ grep LOCAL config.hpp
#define LOCAL_SUPPORT 1
[/vzlogger_r00t]$ git commit -m 'fix cmake -DENABLE_LOCAL=on (to generate "#define LOCAL_SUPPORT 1" in config.h)' CMakeLists.txt

from vzlogger.

note that ENABLE_LOCAL DEFAULTS to on anyway,
so specifying -DENABLE_LOCAL=on is redundant.

from vzlogger.

i suggest we also change the default to off, most users will not need it, and it adds an extra dependency.

my preference would be to enable it if microhttp is available, which is what automake setups usually do...
not sure how to do that with cmake...
can we have an "auto" value for the enable flag?
or should we just print a warning and continue without local support, if it's requested but microhttpd is missing?

from vzlogger.