Expose a logger interface about vmware-go-kcl HOT 7 CLOSED

zap is interesting. https://github.com/uber-go/zap I will take a look on this.

from vmware-go-kcl.

I will write a logrus hook for that.

from vmware-go-kcl.

The only issue is golang log does not provide enough abstraction on common functionalities.
https://golang.org/pkg/log/

We had a very long debate on which logging package to use and finally settled down to logrus. It is quite extensible and our internal codebase uses customized log library with compatible interface as logrus.

https://medium.com/@_orcaman/most-imported-golang-packages-some-insights-fb12915a07

from vmware-go-kcl.

The major advantage of using logrus is that it provides structured logger for Go. The logging result can be easily ingested into ElasticSearch for log analysis.
https://github.com/sirupsen/logrus

from vmware-go-kcl.

Yeah I agree that the golang log is not good enough. We happen to use zap (which is also a structured logger). The problem is mainly that it is a bit painful (but doable with hooks) to redirect logs from logrus to zap. What I have seen libraries doing (like AWS SDK) is to create a custom logging interface (with a default if needed) that the users can then implement with their logger of choice.

from vmware-go-kcl.

I finally wrote the hook https://github.com/Sytten/logrus-zap-hook, though I think an interface would be better ;)

from vmware-go-kcl.

PR: #43
for adding support on both logrus and zap logger.

from vmware-go-kcl.