Describe the bug A clear and concise deion of what the bug

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

I tried your branch, I see a timeout failure, but not panic: <div class="snippet-c

[BUG] govomi keepalive handler panic when login with token then login with basic auth about govmomi HOT 4 CLOSED

lubronzhan commented on August 18, 2024

[BUG] govomi keepalive handler panic when login with token then login with basic auth

from govmomi.

Comments (4)

dougm commented on August 18, 2024

@lubronzhan can you share a test that reproduces this?

from govmomi.

lubronzhan commented on August 18, 2024

Hi @dougm I was adding saml support to CAPV. below are the link to the tests
kubernetes-sigs/cluster-api-provider-vsphere@9347369 (#2171)

I just added loginbytoken func to GetOrCreate function https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2171/files#diff-59fbb0bb5dfeeb4f123f1e9e0a3d12c38a60b839e113b29868cb905755639e13R130

It should login with bear token if userInfo is present, or login with saml sso if cert key pair are presented.

If you want to run the spefific test, you can set GOVC_BIN_PATH then run the test

go test -timeout 30s -run ^TestGetSession$ sigs.k8s.io/cluster-api-provider-vsphere/pkg/session

Thank you

from govmomi.

dougm commented on August 18, 2024

I tried your branch, I see a timeout failure, but not panic:

=== RUN   TestGetSession
    session_test.go:126: 
        Timed out after 30.015s.
        Expected
            <bool>: false
        to be true
--- FAIL: TestGetSession (30.64s)
FAIL
FAIL	sigs.k8s.io/cluster-api-provider-vsphere/pkg/session	31.183s
FAIL

The branch diff and capv layers are a bit much to go through, can you reproduce with just govmomi? Such as by changing one of these tests?

govmomi/session/keepalive/handler_test.go

Line 56 in 72d86e9

sc := soap.NewClient(c.URL(), true)

Or:

govmomi/session/keepalive/example_test.go

Line 42 in 72d86e9

func ExampleHandlerSOAP() {

from govmomi.

github-actions commented on August 18, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

from govmomi.

Recommend Projects