Comments (4)
@lubronzhan can you share a test that reproduces this?
from govmomi.
Hi @dougm I was adding saml support to CAPV. below are the link to the tests
kubernetes-sigs/cluster-api-provider-vsphere@9347369
(#2171)
I just added loginbytoken func to GetOrCreate
function https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2171/files#diff-59fbb0bb5dfeeb4f123f1e9e0a3d12c38a60b839e113b29868cb905755639e13R130
It should login with bear token if userInfo is present, or login with saml sso if cert key pair are presented.
If you want to run the spefific test, you can set GOVC_BIN_PATH
then run the test
go test -timeout 30s -run ^TestGetSession$ sigs.k8s.io/cluster-api-provider-vsphere/pkg/session
Thank you
from govmomi.
I tried your branch, I see a timeout failure, but not panic:
=== RUN TestGetSession
session_test.go:126:
Timed out after 30.015s.
Expected
<bool>: false
to be true
--- FAIL: TestGetSession (30.64s)
FAIL
FAIL sigs.k8s.io/cluster-api-provider-vsphere/pkg/session 31.183s
FAIL
The branch diff and capv layers are a bit much to go through, can you reproduce with just govmomi? Such as by changing one of these tests?
govmomi/session/keepalive/handler_test.go
Line 56 in 72d86e9
Or:
govmomi/session/keepalive/example_test.go
Line 42 in 72d86e9
from govmomi.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale
.
from govmomi.
Related Issues (20)
- Add support for "High with Hyperthreading" option for latency_sensitivity HOT 2
- [BUG] PropertyCollector not populating ScsiLun.AlternateName data correctly/fully HOT 5
- [BUG] govc 0.37.3 datastore.create cannot add nfs41 storage HOT 2
- Add vSAN data migration support for host.maintenance.enter HOT 1
- [BUG] govc fails with 'No host is compatible with the virtual machine' HOT 4
- govc import ova template failing with version v0.38.0 HOT 9
- VCSim should support DRS automation levels
- vcsim: support alarm definitions and trigger on datacenter, cluster and host
- [BUG] Didn't find way to expand datastore capacity HOT 5
- Can't set ftcpt.ftEncryptionMode or migrate.encryptionMode in extra config HOT 3
- Unexported unit Field in performance.MetricSeries Struct HOT 3
- govc support for dual-stack vmk with host.vnic.info HOT 1
- [BUG] host.portgroup.remove always returns NotFound
- Example of how to attach a disk from one vm to another. HOT 3
- [BUG] simulation CancelTask error with info.canceled field HOT 2
- Implement SessionManager.ImpersonateUser(). HOT 2
- [BUG] You can't see all of the content in a specific library HOT 1
- [BUG] How to provide a size when creating a datastore HOT 4
- Update eam api to include authenticationSchema in agentConfigInfo to accessing ovf urls. HOT 1
- [BUG] DatacentersFolders.VmFolder is not a complete path when datacenter is in a datacenter folder. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from govmomi.