Giter Club home page Giter Club logo

Comments (8)

dougm avatar dougm commented on July 19, 2024

Sounds great @gavingray . Maybe stick with the MO type . method name for the cli names, in this case:

The HostSystem.ReconnectHost would be: govc host.reconnect -dc x ...
And HostSystem.DisconnectHost: govc host.disconnect -dc x ...

from govmomi.

bitwisekaizen avatar bitwisekaizen commented on July 19, 2024

I think that reconnect and disconnect are fundamentally different things that what I'm talking about to do here. AddStandaloneHost is a method on the host folder and Destroy is a method on the ComputeResource. Reconnect and Disconnect are used on a HostSystem. Disconnect leaves the host in the inventory and Reconnect assumes that the HostSystem is in the disconnected state. That said, if you'd like to stick closely with the MO paradigms, it would be something more like this.

$ govc datacenter.addstandalonehost -dc=somedatacenter -hostname=somehost ...
$ govc host.destroy -dc=somedatacenter -hostname=something

I think that "addstandalonehost" is pretty wordy though. I think that "addhost" would probably suffice.

I have most of the work here done on the govmomi side. Will just need to add tests and the proper govc implementation. Just let me know what you think and I'll get a PR out stat!

from govmomi.

dougm avatar dougm commented on July 19, 2024

Ah cool, in that case I'd probably go with "datacenter.host.add" or even just "host.add".

from govmomi.

bitwisekaizen avatar bitwisekaizen commented on July 19, 2024

Agreed. I like host.add. Will do! Thanks for the feedback!

from govmomi.

pietern avatar pietern commented on July 19, 2024

@bitwisekaizen Hi Gavin, did you end up working on this? If not, somebody else can pick it up.

from govmomi.

bitwisekaizen avatar bitwisekaizen commented on July 19, 2024

I actually have a changed shelved for this. I got sidetracked for a while, but I should be able to put it up in the next couple of days. Hoping to get more active in the next few weeks.

from govmomi.

pietern avatar pietern commented on July 19, 2024

Thanks for the update.

from govmomi.

dougm avatar dougm commented on July 19, 2024

We have added both 'host.add' (e01555f) and 'cluster.add' (5154339) commands to govc.

from govmomi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.