Comments (10)
jayesh-srivastava
commented on June 11, 2024
1
@anusha94 That would work. I guess 99 percent of the issues are only comments. The ones which are not, I'll work and make the PR for it. The ones with the comment, maybe I can assist anyone on the byoh team who'll be working on this as the number of issues are a lot.
from cluster-api-provider-bringyourownhost.
raunaksingwi
commented on June 11, 2024
I can take this one
from cluster-api-provider-bringyourownhost.
anusha94
commented on June 11, 2024
/assign raunaksingwi
from cluster-api-provider-bringyourownhost.
jayesh-srivastava
commented on June 11, 2024
Hi. Was wondering if @raunaksingwi is still working on this issue. If not then I would like to work on this.
from cluster-api-provider-bringyourownhost.
anusha94
commented on June 11, 2024
/unassign @raunaksingwi
/assign @jayesh-srivastava
Thanks for picking it up @jayesh-srivastava !
from cluster-api-provider-bringyourownhost.
anusha94
commented on June 11, 2024
Hey @jayesh-srivastava !
Let us know if you need any assistance.
from cluster-api-provider-bringyourownhost.
jayesh-srivastava
commented on June 11, 2024
Hi @anusha94 I was working on the issue. There are a lot of files that need modifications. I was thinking of making multiple PRs for different packages as it would be then easier to review. Any thoughts?
Or maybe several commits for the same PR would help too.
from cluster-api-provider-bringyourownhost.
anusha94
commented on June 11, 2024
@jayesh-srivastava
That sounds good!
from cluster-api-provider-bringyourownhost.
jayesh-srivastava
commented on June 11, 2024
Also @anusha94 a lot of issues regarding this are related to structs and functions not having comments. I'll have to manually do this because there is no autofix for golint. How should I do this because to know what each structs and functions do, that is a nearly impossible task I guess.
exported type ScriptExecutor should have comment or be unexported
comment on exported type IFileWriter should be of the form "IFileWriter ..." (with optional leading article)
These are some examples of the issues coming up. Am I able to understand it the right way?
from cluster-api-provider-bringyourownhost.
anusha94
commented on June 11, 2024
@jayesh-srivastava that's a fair call-out. I haven't taken a look at the lint errors myself. But from the issue description, it's indeed mostly comments.
I can create a task list for this issue for different categories of lint errors. Probably then it will be easier for you to work on a subset of these tasks?
One of us on the byoh team can work on the missing comments.
from cluster-api-provider-bringyourownhost.
Related Issues (20)
- run byoh-hostagent-linux-amd64 as root -> Unauthorized HOT 9
- Other linux distributions and support for ubuntu versions? HOT 5
- Upgrade dependency "github.com/kube-vip/kube-vip"
- New release HOT 1
- ./byoh-hostagent --bootstrap-kubeconfig bootstrap-kubeconfig.conf in docker environment is failing with TLS handshake timeout error HOT 1
- Does byoh support Rocky Linux? HOT 1
- Add support for K8s version v1.26.x HOT 1
- Add support for K8s version v1.25.x
- Add support for K8s version v1.27.x HOT 3
- when creating first byoh cluster, its first controller node stuck with 'Installer config is not ready, requeuing' HOT 4
- Host agent throw "imgpkg: Error: Cannot use --recursive (-r) flag when pulling a bundle" HOT 4
- byoh agent launch error "error"="cannot create certificate signing request: Unauthorized" HOT 1
- k8sinstallerconfigtemplates not removed after deleting the cluster via "kubectl delete" command HOT 1
- Bump Go version to 1.19
- Bump cluster-api version to v1.4
- Bump imgpkg version to v0.36
- Migrate to Ginkgo v2
- BYOH Installation Script fails with "no such file or directory" HOT 1
- Move byohosts after clusterctl move to new management cluster HOT 6
- Cannot re-purpose/upgrade a ByoHost; agent log shows "UninstallationScript not found in Byohost" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cluster-api-provider-bringyourownhost.