Giter Club home page Giter Club logo

Comments (5)

tgeorgiev avatar tgeorgiev commented on August 20, 2024

@It4lik looks like you are running your registry (Apache reverse proxy) on port 443. However in the web UI of Admiral, if you don't specify a port, it defaults to 5000, as it is the common docker registry port. But yes, you are right to think that it will default to 443 for https and 80 for http, so we can improve the UI to hint the default port.
Can you try to register your registry as
https://my.private.domain:443

Thanks

from admiral.

It4lik avatar It4lik commented on August 20, 2024

I tried, and that works with https://my.private.domain:443 :)

Mmmh "funny" thing, with nothing provided (and then Admiral puts 5000 as a default behaviour), and an imported docker-compose.yml as a template, I didn't got any problem to run my containers.
So the problem only arises when trying to run a container alone, not when using a template.

from admiral.

igorstoyanov avatar igorstoyanov commented on August 20, 2024

I believe although the error message is displaying the whole url with the added port, this is common confusion for users. We need to add the functionality when a user enters the ip/hostname of registry, if the port is not specified, on focus change, the UI should add the default port. Some other hints or suggestions should show the default ports and default schema as well.

@It4lik, do you have the whole path of the registry before the image in the docker-compose.yaml. This might explain why it is working from docker-compose.yaml.

from admiral.

It4lik avatar It4lik commented on August 20, 2024

Yep I have the whole path of my registry in the "image" section in my compose.yaml.

I think that adding default port while losing the focus is a good idea :)

from admiral.

mshipkovenski avatar mshipkovenski commented on August 20, 2024

Commit d7a89cf addresses the problem:

  • changed default ports to 80/443 for docker and registry hosts
  • added tooltip hints about default scheme and port for registry and
    docker host addresses
  • changed address fields to auto-populate missing scheme and port
    when they lose focus

from admiral.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.