Giter Club home page Giter Club logo

Comments (4)

simon-mo avatar simon-mo commented on July 23, 2024 1

This might be a dup and being investigated here: #5404

from vllm.

tdoublep avatar tdoublep commented on July 23, 2024 1

Also worth mentioning that I see the same behaviour if I remove the top_k from your repro script, e.g.:

sampling_params = []
sampling_params.append(
    {
        "prompt": prompt,
        "temperature": 0.0,
        "max_tokens": 5,
        "repetition_penalty": 2,
    }
)
sampling_params.append(
    {
        "prompt": prompt,
        "seed": 99,
        "max_tokens": 4,
    }
)
sampling_params = sampling_params * 10

sometimes produces:

['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there were two best']
['Once upon a time, there was a young woman']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']
['Once upon a time, there was an old man']

However, if I have both requests be greedy then the issue goes away. I think that is because the offending code only gets excecuted if seq_group.do_sample=True and at least one request has a repetition penalty.

from vllm.

tdoublep avatar tdoublep commented on July 23, 2024

This seems to be related to the fact that some requests have repetition_penalty set and others do not. There is some inconsistent behaviour in this function that means some tensor sizes depends on the order in which the requests get batched together.

See #5639

from vllm.

njhill avatar njhill commented on July 23, 2024

Thanks @prashantgupta24 @tdoublep for finding and investigating this!

from vllm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.