Giter Club home page Giter Club logo

Comments (9)

NathanielInman avatar NathanielInman commented on May 28, 2024 1

Great work on the css but I agree, it's set to be a static 960px in smart-grid.css:
screen shot 2018-05-02 at 11 21 16 am
Having it be relative units, or even better having media queries that allow the main to fill a more reasonable amount of the screen like flexboxgrid or bootstrap would make this more attractive.

Flexboxgrid Example Reference: https://github.com/kristoferjoseph/flexboxgrid

from smart-css-grid.

vladocar avatar vladocar commented on May 28, 2024

Yes it is Safari window doesn't resize to 480px.. You can change 480px in the CSS or try different browser for testing.

from smart-css-grid.

lukejacksonn avatar lukejacksonn commented on May 28, 2024

This was in chrome. The fact that you get any page overflow really doesn't scream responsive; at best this behaves as adaptive. I am not trying to be pedantic or saying that the project is bad but if this is truly a "responsive smart grid" then the demo is not doing it any justice. Like I said, perhaps I am missing something.

from smart-css-grid.

vladocar avatar vladocar commented on May 28, 2024

This is how I view the demo in Chrome Version 66.

screencapture-vladocar-github-io-smart-css-grid-2018-05-02-15_55_27

from smart-css-grid.

lukejacksonn avatar lukejacksonn commented on May 28, 2024

This is not a browser issue.. it behaves the same in chrome and safari (and probably edge). The problem is this is not a "fluid responsive layout system". Perhaps that is not what you were going for, but it is what you are claiming that this is.

rwd-vs-adapt-example

The above gif demonstrates the difference between responsive (on top) and adaptive (on bottom) taken from here. There is another good article here but I feel like I am being pedantic now so I will leave you to it. If this works for people then that is great!

01_responsive-vs-adaptive

02_relative-units-vs-static-units-1

from smart-css-grid.

vladocar avatar vladocar commented on May 28, 2024

@lukejacksonn Thank you for the comment, now I understand what is your point. You can change the main width from 960px to example 90% and the grid flow will be more natural. I will probably switch to %. Unlike other CSS Frameworks the point of this project is personalise anything directly in the main css file.

@NathanielInman Yes, I agree.

from smart-css-grid.

lukejacksonn avatar lukejacksonn commented on May 28, 2024

Good idea 👍 that would demonstrate it better!

from smart-css-grid.

badcat avatar badcat commented on May 28, 2024

Hmm - wouldn't simply changing the .main class from width: 960px; to width: 100%; max-width: 960px; suffice for the demo?

from smart-css-grid.

vladocar avatar vladocar commented on May 28, 2024

@badcat Yes, absolutely. That will work. But I don't want 960px to be the standard I hope people will understand they can change this number into any value or unit. That is the best feature of this project any size or unit will work.

from smart-css-grid.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.