Giter Club home page Giter Club logo

Comments (13)

deimosfr avatar deimosfr commented on August 14, 2024

What do you think in changing "BAT:" to "⚡" sign?

You can find it here http://www.utf8-chartable.de/unicode-utf8-table.pl?start=9728&utf8=string-literal as HIGH VOLTAGE SIGN.

from i3blocks.

vivien avatar vivien commented on August 14, 2024

Looks great!

from i3blocks.

deimosfr avatar deimosfr commented on August 14, 2024

However it seems not working for me in the status bar. Is it for you ?

from i3blocks.

vivien avatar vivien commented on August 14, 2024

Yes, this does the job:

[test]
full_text=⚡

from i3blocks.

vivien avatar vivien commented on August 14, 2024

I had a few changes to your script, like using acpi -b, $! on error, and flatten a bit: https://gist.github.com/vivien/9965922

What do you think? If it's ok for you I'll merge it.

from i3blocks.

deimosfr avatar deimosfr commented on August 14, 2024

I like your commit. Thanks for adding the GPL license. However, I do not really like the arrow at the end. It would be preferable to add just before the '(' or before charging sign:

  • ⚡ 87% ↘(00:20)
  • ⚡↘ 87% (20:00)

The arrow at the end is not implicit in my opinion. Just adding near to the charging sign is the best to understand the meaning, however not the best rendering. That's why I purpose the other solution.

My 2 cents

from i3blocks.

vivien avatar vivien commented on August 14, 2024

I agree, I'll go with the 2nd one, looks better:
The gist is updated, I'll merge it soon. :)

from i3blocks.

deimosfr avatar deimosfr commented on August 14, 2024

I'm wondering if the first (⚡ 87% ↘(00:20)) is not better. 2 symbol just so close is not easily readable in fact :-(

from i3blocks.

vivien avatar vivien commented on August 14, 2024

Makes sense, I'll change that

from i3blocks.

vivien avatar vivien commented on August 14, 2024

Merged, thanks!

from i3blocks.

deimosfr avatar deimosfr commented on August 14, 2024

Thanks to you :-)

from i3blocks.

deimosfr avatar deimosfr commented on August 14, 2024

I was wondering something regarding color. What do you think about removing color when charging ?

from i3blocks.

vivien avatar vivien commented on August 14, 2024

Good idea. I'll push a fix.

from i3blocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.