Giter Club home page Giter Club logo

Comments (8)

vitorgalvao avatar vitorgalvao commented on June 18, 2024 1

i think you also against this info lines (if --install-cask is not used)

I’d be fine with that line, actually. Just change it a bit:

You may upgrade the cask right now from your personal branch:
  brew cask reinstall https://raw.githubusercontent.com/muescha/homebrew-cask/cask-repair_update-dash/Casks/dash.rb

It should likely wait until #62, though, since before then your username isn’t in a global variable.

from tiny-scripts.

vitorgalvao avatar vitorgalvao commented on June 18, 2024 1

@muescha Done in ba09a1d and 0db5758.

from tiny-scripts.

vitorgalvao avatar vitorgalvao commented on June 18, 2024

This was already discussed somewhere else. I agree and it’s on the list.

from tiny-scripts.

muescha avatar muescha commented on June 18, 2024

@yurikoles there is still this option:

-i, --install-cask                     Installs your updated cask after submission.

from tiny-scripts.

vitorgalvao avatar vitorgalvao commented on June 18, 2024

@muescha That’s the one, yes. It was added after this feature request, though. It’s quite a recent feature.

from tiny-scripts.

muescha avatar muescha commented on June 18, 2024

because i don't see this option when i used the script i would like to have an question to the interactive mode to install it now:

Install your updated cask now? ([y]es / [n]o)

y: install the cask from ${cask_file}
n: then it display a message:


  Submitted (https://github.com/caskroom/homebrew-cask/pull/30280)

  Install your updated cask now? ([y]es / [n]o)
  >n

  You decided not to install your updated cask now.

  you can install your updated cask from your local branch: 
  brew cask install https://raw.githubusercontent.com/muescha/homebrew-cask/cask-repair_update-dash/Casks/dash.rb

i try to create a pull request for it.

i would like to use the raw cask from pull request, but i don't know how to get the url for it :(

https://raw.githubusercontent.com/muescha/homebrew-cask/cc3743280181a943680a3db7690f84997b99a59e/Casks/dash.rb

from tiny-scripts.

vitorgalvao avatar vitorgalvao commented on June 18, 2024

i would like to use the raw cask from pull request, but i don't know how to get the url for it :(

No point, it’s much easier to use the locally modified file (which is what it currently does).

i try to create a pull request for it.

Please don’t, as I won’t accept it. I don’t want to create another blocking prompt. It also wouldn’t fit well with options such as --blind-submit, since sometimes you want to have both. If you always use --install-cask, then you can alias cask-repair='cask-repair --install-cask in your shell.

from tiny-scripts.

muescha avatar muescha commented on June 18, 2024

I don’t want to create another blocking prompt

i agree - an additional blocking prompt makes no sense.

i think you also against this info lines (if --install-cask is not used)

  created branch `muescha/cask-repair_update-dash` 

  Submitted (https://github.com/caskroom/homebrew-cask/pull/30280)

  you can now install your updated cask from your local branch: 
  brew cask install https://raw.githubusercontent.com/muescha/homebrew-cask/cask-repair_update-dash/Casks/dash.rb

from tiny-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.