cask-repair: Cannot update Casks with language stanza about tiny-scripts HOT 6 CLOSED

Unfortunately, this is one of those cases cask-repair (which is just a batch script) will not be able to handle correctly due to the variance in those casks. It’s the same issue with url do blocks (though I think I already detect and stop the script on those. The solution here will be to cripple cask-repair to not handle those.

I’ll do it on the cask-repair cleanup (I’ve been accumulating a list of what needs to be done).

from tiny-scripts.

Thanks for that. I believe there is only one Cask that uses a url do block (audacity).

So for the Casks with a language stanza, the only way to update them is to check the sha256 of each language version and update them manually? If so, should we add a note to the instructions?

I suppose there is already a note there:

If there is a more complicated change, or there is a case where cask-repair fails, you can also follow the steps in Adding a Cask to do the same thing manually. Remember to update the version and shasum values, as well as the appcast checkpoint, if there is one.

from tiny-scripts.

So for the Casks with a language stanza, the only way to update them is to check the sha256 of each language version and update them manually?

Yes, because there’s no way (that I’m thinking of, in a bash script) to reliably get all languages the cask uses and their organisation in a reliable way that works for all casks.

As I said, I should add a note on cask-repair that’ll stop changes on such casks and as such you’ll always need to manually update. When that happens, a note on the instructions should not be necessary.

from tiny-scripts.

Sound good.

from tiny-scripts.

Hi, I recently started using your script and I wondered if there's anything that can be done about this language stanza problem.

Yes, because there’s no way (that I’m thinking of, in a bash script) to reliably get all languages the cask uses and their organisation in a reliable way that works for all casks.

Would it be such a big problem? I think it's worth taking a shot. I'm gonna try to come up with some way and maybe submit a PR if you don't mind. I'm not a bash genius though 😄

from tiny-scripts.

Would it be such a big problem?

Yes. See below.

I think it's worth taking a shot.

It’s not. There are not enough casks with language to be worth the time it’ll take to implement correctly.

I'm gonna try to come up with some way and maybe submit a PR if you don't mind.

I don’t mind and you can submit a PR, but it’s unlikely I will accept it.

I'm not a bash genius though

And this is why.

This is not a simple issue to tackle, and it requires a hackish solution, due to how the script works (programatically editing the cask text file). One that I’ll have to be the one to maintain and fix, which will be too time consuming to be worth it.

You are, naturally, free to surprise me and prove me wrong. But if you do, please follow my style in the script. My style is pretty consistent so it should be easy to follow. It’s common that I get PRs that ignore my style to such an extent I basically have to reimplement the whole feature myself. I won’t do it in this case (again, due to its complexity)

from tiny-scripts.