Giter Club home page Giter Club logo

Comments (1)

csr632 avatar csr632 commented on June 2, 2024 1

Actually, vite support vite.config.ts so we can already use esmodule import in vite config!
In vite.config.ts, we can already use import reactPlugin from 'vite-plugin-react' because typescript already handle commonjs-esm interop for us. The transpiled config will look like this:
image

But I still aggree with you that we should not use commonjs export. Because:

  • A plugin may export a config function or config object.

    By the way, I think we should encourage all plugins to export config function instead of plugin object. Make things consistant like rollup does.

  • A plugin may also export some helpers or constants

It is not convenient for commomjs to export these values in index.js (we may have to expose those helpers as propterties of the config functon).

from vite-plugin-react-refresh.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.