Service Worker Not being minified about nuxt HOT 4 OPEN

@logotip4ik I'll review latest changes in Nuxt, it is weird, mode should be production and injectManifest should minify the sw (the pwa plugin includes process.env.NODE_ENV="production" via Vite define option in the custom build): https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/modules.ts#L95

from nuxt.

@logotip4ik found the problem:

• by default Vite will use esbuild to minify, since we're using a custom Vite build to build the service worker, Vite will use esbuild since pwa plugin will not provide/change the build.minify option
• vite-plugin-pwa is using es as default Rollup format to build the service worker, but Vite will not remove empty spaces https://vitejs.dev/config/build-options.html#build-minify:

  Note the build.minify option does not minify whitespaces when using the 'es' format in lib mode, as it removes pure annotations and breaks tree-shaking.

You can change the format using iife, the service worker is minified but the code generated is wrong and will not work.

You can check it here in this SB fork : https://stackblitz.com/edit/nuxt-starter-al3pyt?file=nuxt.config.ts.
If you run yarn build the output will be on server/public folder, I've changed nitro output.dir and there is an issue on nitro about custom output (also tried with terser plugin with no luck).

from nuxt.

anyway, your sw has errors: missing race and debug variables and error in L55

from nuxt.

anyway, your sw has errors: missing race and debug variables and error in L55

I thought that they would be somehow inlined at the build time 😅. I took this example from vite-pwa website (https://vite-pwa-org.netlify.app/workbox/inject-manifest.html#network-first-strategy). Should i open pr to fix this ?

from nuxt.