when this method in node_modules about vite-plugin-dynamic-import HOT 8 CLOSED

v1.3.0 support 👉 node_modules

from vite-plugin-dynamic-import.

I'm facing the same problem when expecting vite-plugin-dynamic-import will work on some imported node_modules libs.

For instance, to reproduce :

create a basic vite project
install @ionic/core : npm install @ionic/core
Import it in your index.ts file :

Hey 👋 @fcamblor it works to me. @v1.3.0

dynamicImport({
  filter(id) {
    // `node_modules` is exclude by default, so we need to include it explicitly
    if (id.includes('node_modules/@ionic')) {
      return true
    }
  },
}),

from vite-plugin-dynamic-import.

@caoxiemeihao, I've seen your README update from yesterday but didn't got a chance to try it out before you did.

Thanks a lot for a that fast workaround ;-)

from vite-plugin-dynamic-import.

I too am having issues trying to dynamically import from node_modules folder

from vite-plugin-dynamic-import.

Who can provide a minimal reproduction repo?

from vite-plugin-dynamic-import.

https://github.com/Miofly/vue-admin-plus

plugin is in vite-common-config

from vite-plugin-dynamic-import.

I'm facing the same problem when expecting vite-plugin-dynamic-import will work on some imported node_modules libs.

For instance, to reproduce :

• create a basic vite project
• install @ionic/core : npm install @ionic/core
• Import it in your index.ts file :

import { defineCustomElements as defineIonicCustomElements } from '@ionic/core/loader';

....

defineIonicCustomElements();

• Include a simple <ion-button>hello</ion-button> in your app
• You will see an error in the console :

... and this file is not handled properly by vite (I assume this is because it is outside of my project's scope, because located in node_modules)

from vite-plugin-dynamic-import.

@caoxiemeihao

i use latest version,Although the function is not affected, the following error will occur when starting

is seem to import type error

repo link:https://github.com/Miofly/vue-admin-plus

from vite-plugin-dynamic-import.