Giter Club home page Giter Club logo

Comments (12)

markcmiller86 avatar markcmiller86 commented on June 15, 2024 1

After some off-line discussion, we've converged on the following

  • Remove all copyright verbiage from all source headers (.C, .h, CMake, shell, python, etc.)
  • In the top-level COPYRIGHT file, include verbiage to the effect...
    Copyrights and patents in the VisIt project are retained by contributors.
    No copyright assignment is required to contribute to VisIt.
  • The top-level COPYRIGHT file will be the only one requiring yearly update to incriment the date range.

from visit.

gonsie avatar gonsie commented on June 15, 2024

FYI, the guidance we are talking about is on this page.

The lack of details on a requirement to have details at the top of source files is what means you can remove it. Note that Spack chooses to have a short notice at the top of some files. I believe that cardioid choose to go with SPDX identifiers (details at the bottom of the page)

from visit.

tgamblin avatar tgamblin commented on June 15, 2024

I generally think it is clearer to use a short header that states the copyright and license -- that's what ours do. It's basically just "copyright LLNS and the Spack developers" and "SPDX-License-Identifier: (Apache-2.0 OR MIT)":

# Copyright 2013-2018 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)

from visit.

gonsie avatar gonsie commented on June 15, 2024

Spack’s approach doesn’t solve the “update the copyright date each year” problem. But you can choose to only have the comment at the top of files that are deemed important enough.

from visit.

markcmiller86 avatar markcmiller86 commented on June 15, 2024

Well, I wanted to get away from updating 7,000+ source files every 365 days. If that isn't going to be possible...I am not sure I care about shrinking 50 line header down to 2.

from visit.

gonsie avatar gonsie commented on June 15, 2024

It’s possible / technically allowable... just maybe not what you want. SCR has decided to remove in-code copyright comments all together. Visit has a broader reach and your team may be more concerned with people looking at the source files and copying.

from visit.

tgamblin avatar tgamblin commented on June 15, 2024

FWIW, the Rust project, which we based the Spack headers on, has since made some changes to remove their headers:

Maybe we should remove them in Spack, too. It's definitely more maintainable.

from visit.

markcmiller86 avatar markcmiller86 commented on June 15, 2024

Well, so I guess the true problem is the constantly change current year in the headers. If we could adjust text, as rust team discussed, so that date/years were included in only a minimal set of places, then I would welcome that.

For example, if we could change header to something like...

Copyright 2000-Present Lawrence Livermore National Security, LLC. and other VisIt project developers.
For present year and additional details, see the top-level COPYRIGHT file.

from visit.

cyrush avatar cyrush commented on June 15, 2024

@markcmiller86 if thats acceptable, that looks great.

from visit.

markcmiller86 avatar markcmiller86 commented on June 15, 2024

@tgamblin @gonsie...who should we seek further guidance from regarding this?

from visit.

tgamblin avatar tgamblin commented on June 15, 2024

I put a question in to IPO and legal. I'm genuinely curious.

from visit.

markcmiller86 avatar markcmiller86 commented on June 15, 2024

Ok, we met with lab legal to review these actions and some other questions. Slight modification to above...instead of removing copyright verbiage of any kind from headers, we will replace existing verbiage with a short statement for the reader to find copyright info at the top-level COPYRIGHT file. Other steps remain the same.

from visit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.