Giter Club home page Giter Club logo

Comments (8)

phibr0 avatar phibr0 commented on August 22, 2024 1

Working on a fix, as a workaround right now you can press ctrl + e twice after switching panes.

from tab-switcher.

AngelusDomini avatar AngelusDomini commented on August 22, 2024 1

It works now with the new update (0.0.4). Thanks so much!

from tab-switcher.

AngelusDomini avatar AngelusDomini commented on August 22, 2024

Good to know that you're working on it as well as about the workaround 😁

from tab-switcher.

pjeby avatar pjeby commented on August 22, 2024

If you don't care about wraparound, you can use the built-in commands to "focus on pane to the left", "focus on pane to the right", "up" and "down". They don't wrap from first to last, but you can bind them to the same keys and use them in place of this plugin.

from tab-switcher.

AngelusDomini avatar AngelusDomini commented on August 22, 2024

If you don't care about wraparound, you can use the built-in commands to "focus on pane to the left", "focus on pane to the right", "up" and "down". They don't wrap from first to last, but you can bind them to the same keys and use them in place of this plugin.

Doesn't seem to be as convenient for me; I'm not able to cycle through the panes with this workaround which forces me to switch between the two hotkeys whenever I reach the last pane on either side—which makes it a more frequent inconvenience when you usually only have two panes open instead of more.
Sorry, didn't know what you meant by "wraparound," yeah I do care about that lol

Also, @phibr0, not sure if you've addressed this issue on the newest update. Have tested it and still doesn't work, even though this issue has been closed.

from tab-switcher.

phibr0 avatar phibr0 commented on August 22, 2024

It seems to be working fine for me.. Did you restart Obsidian after updating the Plugin?
Video

from tab-switcher.

pjeby avatar pjeby commented on August 22, 2024

I just updated to 0.0.3 and restarted, and while the new commit fixes the focusing issue, it does not seem to support wraparound either.

However, in my case, that's probably due to an Obsidian issue that prevents making a sidebar document active. (Obsidian allows dragging a document into a sidebar pane, but it doesn't allow making it "active", even though you can click into it and edit it.) Sidebar documents are included in iterateLeaves() and getLeavesOfType("markdown"), so this plugin attempts to cycle through them. But since they cannot be made active, the previously-active leaf remains active, so the cycling stops.

One way to fix that would be for this plugin to skip such leaves when moving forward or backward. A simple way to do this is to check that the workspace.activeLeaf has actually changed after calling setActiveLeaf(). If it hasn't, then the leaf wasn't suitable, and needs to be skipped in the rotation. This approach should be forward compatible in case Obsidian ever actually allows sidebar leaves to become active.

from tab-switcher.

phibr0 avatar phibr0 commented on August 22, 2024

Seems like this is a another Issue

from tab-switcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.