Giter Club home page Giter Club logo

Comments (1)

jd327 avatar jd327 commented on July 17, 2024

Yeah I've thought about that too. So, currently Hashids does not eliminate, but uses these as separators: "c, s, f, h, u, i, t". That way if you want to encode [1, 2, 3], and 1 encodes to "A", 2 encodes to "B", and 3 encodes to "C", your hash might be: "AsBuC".

If I were to remove all vowels, calculation would be faster (which is a plus), but the generated hashes would be longer - additionally they might not look as "random" since there'd be less characters (and some people might not even like that their hashes don't have vowels).

But if I were to use all vowels as separators (instead of the current characters), that doesn't help with the curse words either -- if 1 encodes to "F" and 2 encodes to "CK", we'd have a problem when "u" is the separator.

So, I'm hesitant to use the approach of eliminating all vowels because 1) I'm not sure the solution outweighs the problem and 2) I haven't noticed it being that big of a problem yet (I've been using Hashids at 3 companies so far - with tons of generated hashes and have yet to see a bad word - but, on the other hand I've only been keeping an eye out for English words).

But, ultimately it all depends on the community. If there's a strong support for it (whether it's this approach or any other), I'll gladly readjust Hashids. And if you decide to modify Hashids to use this technique, tell me so I can link to your repo so people have some alternatives.

from hashids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.