Circular References - Unreachable output-targets about formulas HOT 4 CLOSED

I manage to solve the circular reference.

When you invoke the finish method of ExcelModel add circular=True. It invokes the method solve_circular, that solves the cycles breaking the loops when it is possible.

from formulas.

@vinci1it2000 This error is hit when trying to compile a function for solve. Using your approach does fix the issue. I can include it in a PR I want to open this week which includes numerous bug fixes and added excel functions.

from formulas.

@vinci1it2000 When calling compile in excel.py to create the function what should be done with the circular tokens?

        for k, v in sh.selector(dsp.data_nodes, res, allow_miss=True).items():
                dsp.set_default_value(k, v.value)

That is failing when a CIRCULAR token is hit because v == XlError which doesn't have value attribute. I tried just skipping CIRCULAR toknes completely (if(k != CIRCULAR)) but my outputs were incorrect in that case, but it did come up with a solution. Should I special case CIRCULAR nodes when setting defaults before compiling the function?

EDIT: Actually the calculation is correct if CIRCULAR is just ignored when setting default. I will go with this for now.

from formulas.

CIRCULAR is a special data node that has a special default value ERR_CIRCULAR. There are other nodes that can have this value. So I suggest a more pythonic way:

                 for k, v in sh.selector(dsp.data_nodes, res, allow_miss=True).items():
                          try:
                                dsp.set_default_value(k, v.value)
                          except AttributeError:
                                pass

One question: What is the scope of setting the defaults values of the dispatcher? Probably I can help with the usage of schedula.

from formulas.