Giter Club home page Giter Club logo

Comments (3)

h2o64 avatar h2o64 commented on July 24, 2024

I think I understand why the assertion is not failing in core_test.py . The flow used is initialized with init_zeros=True making it the identity map

normalizing-flows/normflows/core_test.py

Lines 27 to 28 in 0466e7f

s = MLP([latent_size, 2 * latent_size, latent_size], init_zeros=True)
t = MLP([latent_size, 2 * latent_size, latent_size], init_zeros=True)

Because the identity map is its own inverse, the jacobians are the same.

from normalizing-flows.

VincentStimper avatar VincentStimper commented on July 24, 2024

Hi @h2o64,

thanks for spotting this! I have added this method recently and haven't used it yet, which is why I did not notice it.

I made a PR solving this, feel free to have a look.

Best regards,
Vincent

from normalizing-flows.

h2o64 avatar h2o64 commented on July 24, 2024

Looks good to me !

Thank you for your awesome package,
Louis

from normalizing-flows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.