[1.7.1] Group name about opencart-overclocked HOT 5 CLOSED

Good point. I will have a look ...

from opencart-overclocked.

Alright, I had a look today ...

I can see the practicality of having a getGroupName() function in system/library/user.php, but I don't think it is being used enough to justify its addition to the user class.

However, there is a function in the admin user model file to get the User Group Name.
It requires 2 parameters: $user_id and $user_group_id.
It can be called anywhere under admin provided the model file is loaded:
$group_name = $this->model_user_user->getUserGroup($user_id, $user_group_id);

So I will not add it to the user class at this stage.

from opencart-overclocked.

I have the case in one of my OC extension where i needed current user group id and group name.
In your 1.7, group ID is already set at login. Having group name in the same query is easy.
This prevent doing +1 query.
With getUserGroup($user_id, $user_group_id), you need first to have current user group id (+1 query on OC).

from opencart-overclocked.

All you have to do is change

SELECT permission

to

SELECT name, permission

and add a function getGroupName() in library/user.php
Cost nothing.

from opencart-overclocked.

Yes, I actually tried that, but all I had as a result was a Url.
I'm not exactly sure why.
I will try to implement this again in time.

from opencart-overclocked.