Giter Club home page Giter Club logo

Comments (3)

joshq00 avatar joshq00 commented on June 19, 2024 1

I also ran into this. It turned out gzip was the culprit for me.
I added this:

decorateRequest: function ( req ) {
    req.headers[ 'Accept-Encoding' ] = 'utf8';
    return req;
}

and data.toString( 'utf8' ) stopped giving me jumbled poo-poo

from express-http-proxy.

villadora avatar villadora commented on June 19, 2024

Hi Tophe,
As the first problem, I tried it, you should try res.text in test case. It works, I comments on your commit.

For api.github.com, it's very wired, I thought there might be a https relative problem, but I tried https://httpbin.org, everything works fine. I doubt it's somehow relative to how the code to decode the buffer. I'll keep it in the issues list to when I can finally take time to figure it out.

PS: in the final response, resp.body contains the correct json object =.=

from express-http-proxy.

mlenkeit avatar mlenkeit commented on June 19, 2024

Not sure if this is related: I faced a similar issue where I couldn't access any data from the response in the intercept hook (also when proxying to Github), yet I saw the response in the browser. It turned out to be a caching-related issue.
I added this to solve the problem.

decorateRequest: function(req) {
  delete req.headers['if-modified-since'];
  delete req.headers['if-none-match'];
  return req;
}

from express-http-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.