Giter Club home page Giter Club logo

Comments (9)

skullbearer avatar skullbearer commented on August 16, 2024

Just to add, it is returning IMyShipConnector.Status = MyShipConnectorStatus.Connected.

from performance-improvements.

viktor-ferenczi avatar viktor-ferenczi commented on August 16, 2024

What was the exact problem? Crash inside the PerformanceImprovements plugin?

If crash, the could you please attach a stack trace (or even better a full log)?

Server or client?

from performance-improvements.

skullbearer avatar skullbearer commented on August 16, 2024

No crash on the server or the plugin or client. This is returning null to the PB API call for IMyShipConnector.OtherConnector or IMyShipConnector.OtherConnector.CubeGrid.

from performance-improvements.

viktor-ferenczi avatar viktor-ferenczi commented on August 16, 2024

Try to disable the Fix grid merge feature in the plugin config.

What it does may be related to your issue: "Disable conveyor updates during grid merge (MyCubeGrid.MergeGridInternal)"

Does it solve your problem? If not, then please try to disable half of the remaining tests each time and narrow down which one is causing the issue.

The workaround is to keep that fix (or fixes) disabled.

from performance-improvements.

skullbearer avatar skullbearer commented on August 16, 2024

We did disable that performance patch (the conveyor updates) and it did seem to resolve the issue, even after the patch was re-enabled. We've been unable to replicate it, but that it was immediately corrected upon toggling that option implies a causal link. Why it doesn't return, we don't know. We did other, unrelated to your plugin things, to dramatically improve simspeed, so it could be that the worker threads are completing in the same tick reliably enough that the problem is not occurring. Connecting two grids during low simspeed may replicate it.

from performance-improvements.

viktor-ferenczi avatar viktor-ferenczi commented on August 16, 2024

We did other, unrelated to your plugin things, to dramatically improve simspeed

What else have you configured exactly to improve performance? Maybe it gives some clue.

from performance-improvements.

skullbearer avatar skullbearer commented on August 16, 2024

Cleaned up grid clusters, hangared a lot of grids. Nothing that would be related other than to simspeed.

The problem has returned so we're trying to sync up with a player experiencing it to try and confirm which plugin setting is causing it. Personally I do not think that the conveyor during merge would be the cause because the affected Keen code only occurs when a full grid merge occurs, such as with a merge block or a copy-paste of a grid onto another grid.

from performance-improvements.

viktor-ferenczi avatar viktor-ferenczi commented on August 16, 2024

Thank you for narrowing this issue down to a specific config option.

from performance-improvements.

viktor-ferenczi avatar viktor-ferenczi commented on August 16, 2024

Does this issue still happen with game version 1.203.022?

from performance-improvements.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.