Giter Club home page Giter Club logo

Comments (6)

paulsitebuildercorp1 avatar paulsitebuildercorp1 commented on July 24, 2024

After reviewing one of the closed issues I realized this was supposed to be addressed. The bug is still there in the minified code (different but the same basic problem). Its not finding commentID and throwing errors. Also the use of a double assignment.
var contentChanged = content != this.commentsById[commentId].content; at line 542ish is odd.

from jquery-comments.

paulsitebuildercorp1 avatar paulsitebuildercorp1 commented on July 24, 2024

I pulled the version from the other branch gh-pages. This version does not throw the error. Although it still is using the double assignment methods which is not recommended. (Netbeans generates a warning here).

from jquery-comments.

CaiqueJhones avatar CaiqueJhones commented on July 24, 2024

This version works: http://viima.github.io/jquery-comments/demo/js/jquery-comments.js

from jquery-comments.

paulsitebuildercorp1 avatar paulsitebuildercorp1 commented on July 24, 2024

I pulled that version and tried it. If I format my data as standard json (being pulled in via the getComments: method via a php url I get an error.

TypeError: commentsArray.map is not a function
var commentModels = commentsArray.map(function(commentsJSON){

The format of the data returned is
{
"id": 1,
"parent": null,
"created": "2015-01-01",
"modified": "2015-01-01",
"content": "Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Sed posuere interdum sem. Quisque ligula eros ullamcorper quis, lacinia quis facilisis sed sapien. Mauris varius diam vitae arcu.",
"fullname": "Simon Powell",
"profile_picture_url": "https://app.viima.com/static/media/user_profiles/user-icon.png",
"created_by_admin": false,
"created_by_current_user": false,
"moderation_pending": false,
"upvote_count": 3,
"user_has_upvoted": false
},
{
"id": 2,
"parent": null,
"created": "2015-01-02",
"modified": "2015-01-02",
"content": "Sed posuere interdum sem. Quisque ligula eros ullamcorper quis, lacinia quis facilisis sed sapien. Mauris varius diam vitae arcu.",
"fullname": "Administrator",
"profile_picture_url": "https://app.viima.com/static/media/user_profiles/admin-user-icon.png",
"created_by_admin": true,
"created_by_current_user": false,
"moderation_pending": false,
"upvote_count": 2,
"user_has_upvoted": false
},

Direct copy of the sample data. I also tried converting to an array by enclosing it in [] both with an assignment to the var and not. (var commentsArray = [ etc). So there is some stupid simple thing I'm missing here. Do I need to json encode the return string? Or is there as this indicates a missing or renamed function or method in the script?

Any help here would be appreciated.

from jquery-comments.

jessenieminen avatar jessenieminen commented on July 24, 2024

There was indeed a bug with the latest commits, a small change we made in #6 was the reason for this so we reverted the changes made there.

Now it should work again.

from jquery-comments.

danman1234 avatar danman1234 commented on July 24, 2024

Really not working and not fixed, i have exactly the same problem

i give the comment back as one singe somment:

echo json_encode(array('upvote_count' => 2, 'created_by_current_user' => true, 'created_by_admin' => false, 'id' => 3 , 'parent' => null, 'created' => '2015-01-03' , 'modified' => '2015-01-03', 'content' => '@Hank Smith sed posuere interdum sem.\nQuisque ligula eros ullamcorper https://www.google.com/ q' , 'fullname' => 'test' , 'profile_picture_url' => 'https://app.viima.com/static/media/user_profiles/user-icon.png'));

How can i return more then 1 comment in one array?

from jquery-comments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.