Firefox Issues about jquery-comments HOT 7 CLOSED

Hi,
thanks for your comment!

I can't seem to reproduce any of those issues with Firefox (or any other browser for that matter). Could it have something to do with your implementation?

If you could provide us with Codepen or similar that reproduces the issue, we could take a look at this in a couple of weeks when we're going through the current issues and that one pull request for this library.

from jquery-comments.

Hi.

I cant find the problem in the implementation, becuase seems like browser problem becuase works on Chrome and not on Firefox.
Here is an preview http://goo.gl/ob1Svl - Projects->Project->Discussions - Click on some discussion.

I already tested on Chrome is working good but not on Firefox.
Will be appreciated if any idea how this can be fixed..
Thanks.

from jquery-comments.

Hi, thanks for getting back! The link returns 404, could you try again?

from jquery-comments.

Hi.

I updated the link. Initialy was posted as 404 the i change it.
On May 16, 2016 6:53 PM, "Jesse Nieminen" [email protected] wrote:

Hi, thanks for getting back! The link returns 404, could you try again?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#51 (comment)

from jquery-comments.

Thanks. I can confirm that I could replicate the bugs in the pic in your code but still can't do the same in any of my implementations with the latest code so I think this must be an implementation specific thing.

A quick look at the data in your comment model shows that your dates are not the standard string representation with timezone that Date() is looking for so I'm not at all surprised that the sorting doesn't work. Chrome and other browsers just work around the issue whereas Firefox doesn't. Please change the format returned by your API to fix the issue. Also, the date of newly created comments is an hour in the past for me so you might to want to fix that bug too while you're at it :)

As for the issue with the
element, I'd suspect a double escape somewhere in your code prior to or after parsing the date.

from jquery-comments.

Hi.

Thanks for the reply.
I was able to fix the new lines problem.. About the 1 hour in the past this is based on timezone thats why showing like this..

About the date i'm passing the dates via the API as Y-m-d H:i:s but as i can see Y-m-d H:i:s is not accepted right? Should be just Y-m-d? If yes in this case the sorting wont be 100% accurate..
Ex if there is 5 comments with the same date in format Y-m-d how will be sorted then?

Also when i try to pass it like Y-m-d its not accurate again.

Update:
Actually i solved the date problem passing miliseconds as date created. I think its good solution like this?
Thanks.

from jquery-comments.

Good to hear! Yes, milliseconds are a good way to do it.

Usually APIs have either milliseconds or then use the Javascript native date format: "2016-05-13T06:21:28.961Z". In both of these cases, you should probably save these as UTC time and then have the browsers convert the times to the correct timezone for each user.

from jquery-comments.