Cannot read property 'parent' about jquery-comments HOT 13 OPEN

Can you paste a code example or (preferably) a link to a CodePen demonstrating the issue so that I could dig into the problem more deeply?

from jquery-comments.

You can check this url http://codepen.io/shandy05/pen/EPqeGm, try to reply and reload

from jquery-comments.

There was a bug indeed when comparing the dates of two comments, this is now fixed in the newest version 1.1.1. The fix was done in: 5a0b13a

from jquery-comments.

still not working :(

from jquery-comments.

Now I got it working in codepen after 5d5bed4. Still, I don't understand why it works after this commit, I think there are some issues in your data. For example, there may be a parent comment that has a timestamp later than one of its replies

from jquery-comments.

ok, thanks for help

from jquery-comments.

Did you get it working after the latest commit?

from jquery-comments.

sometimes working, I don't know where is problem

from jquery-comments.

Unfortunately I don't have time to investigate this issue right now but you can do so if you will. The problem is in sorting the comments at the beginning, line 635:

                comments.sort(function(commentA, commentB) {
                    var createdA = new Date(commentA.created).getTime();
                    var createdB = new Date(commentB.created).getTime();
                    if(sortKey == 'oldest') {
                        return createdB - createdA < 0;
                    } else {
                        return createdB - createdA > 0;
                    }
                });

For some reason the comments are not sorted by date and thus the parent of a certain comment cannot be referenced in the commentsById dictionary.

from jquery-comments.

ok, i will try to investigate, thanks jjtykkyl :)

from jquery-comments.

I found the same bug on my own project. Also i figured out that my mistake was I got some comments from server without date and this was the reason, because comments firstly sorted on line 272:
// Sort comments by date (oldest first so that they can be appended to the data model

I removed all comments without date and it works

from jquery-comments.

Hello, was this problem resolved? Because i tried everything suggested above, and the problem is still coming. I noticed that when i add more than a certain amount of data.. i deleted all the data and tried again, the same problem..I amended the comments-data.js and added one more comment, and it gives the same problem, can that more than 10 comments causes problems or am I doing something wrong? Thanks!

from jquery-comments.

Hi everybody! It's been a while since last post here, but I might have a good news for those who still struggle with this strange bug or will in the future. A bit of a workaround...

When implementing this plugin, make sure to have timeFormatter() function added to your config. It must return time format that include time along date (e.g. G:i M, d Y). That is the only way to have proper loading order of comments, and to avoid missing parent for comment replies.

Hope this will help someone.

from jquery-comments.