Giter Club home page Giter Club logo

Comments (4)

jjtykkyl avatar jjtykkyl commented on July 24, 2024

Thanks for participating this project! "Read-Only" mode is something that we have considered doing but is not the highest priority at the moment. Based on your pull-request, you seem to know what you are doing so feel free to create another pull-request out of "Read-Only" mode.

from jquery-comments.

sadortun avatar sadortun commented on July 24, 2024

Hi Joona,

Thanks ! I also have quite higher priorities, but it's on my infinitly growing todo-list! It probably will have to wait since i'll be away for the next 5 weeks.

There is 3 ways i see to implement this:

  1. Hide all mutable controls
    Can be done by adding a css class to controls: ex: .jquery-comments-mutable
    When read-only mode activated, $('.jquery-comments-mutable').hide();`
  2. Disable all mutable controls, but let them be visible.
    Can be done by adding a css class to controls: ex: .jquery-comments-mutable
    When read-only mode activated, $('.jquery-comments-mutable').disable();`
  3. Leave mutable controls activated, but ask for credentials/login
    TBD using callbacks, ensuring the current state is preserved during the authentification process.

What do you think?
Samuel

from jquery-comments.

jjtykkyl avatar jjtykkyl commented on July 24, 2024

I would just hide all the mutable controls: disabling them might confuse users as they don't necessarily know why the buttons are disabled and prompting for credentials can already be done with callbacks (check https://app.viima.com/viima/?activeItem=60).

from jquery-comments.

jjtykkyl avatar jjtykkyl commented on July 24, 2024

I'm happy to let you know that this feature has been implemented to version 1.1.0. The functionality can be enabled by setting the new variable "readOnly" to true

from jquery-comments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.