Giter Club home page Giter Club logo

Comments (12)

mikita-simanavets avatar mikita-simanavets commented on August 16, 2024 1

@SKART1 Yes, you are right! Thank you for a hint
@vidstige it works well. I haven't run your tests, but in my project it works without any noticeable problems

from jadb.

SKART1 avatar SKART1 commented on August 16, 2024

@mikita-simanavets yo may refer any of them with the help of jitpack

from jadb.

mikita-simanavets avatar mikita-simanavets commented on August 16, 2024

@SKART1 thank you a lot! Yes, JitPack doing what a want

dependencies {
    compile 'com.github.vidstige:jadb:master-SNAPSHOT'
}

from jadb.

SKART1 avatar SKART1 commented on August 16, 2024

It is better to refer "stable" artifact if you are dealing with any build system. It guarantees same result for two builds.
Snapshot may refer to new artifact with new features/bugs, while referring commit will guarantee same jar
Try something like this:

dependencies {
    compile 'com.github.vidstige:jadb:master-f9cfdfa419'
}

from jadb.

vidstige avatar vidstige commented on August 16, 2024

Wow, time really flies doesn't it? We should definitely make a new release with all the good stuff. Just to get a small sample here. Are you using the latest? Does it work well? If so I can tag a new release right away.

from jadb.

vidstige avatar vidstige commented on August 16, 2024

Alright, I pushed a new branch with a commit and tag, see #79. I pushed a tag in there as well. Let me know if it looks good and we'll merge it

from jadb.

mikita-simanavets avatar mikita-simanavets commented on August 16, 2024

Guys, it looks like you forgot to make a release. There is no information about new version at Releases page and at JitPack repository (both show v1.0.1 as latest). Please, make it. If I can help with it, please, let me know. Thank you!

from jadb.

vidstige avatar vidstige commented on August 16, 2024

Oh, I thought all tags where automatically released. I just quickly summarized all the commits in a new relase - v1.1.0. I don't know if jitpack will pick it up, but lets keep an eye out.

Also do you gentlemen know of master should look? Should there be "1.2-SNAPSHOT" in the pom.xml file? 🤔

from jadb.

SKART1 avatar SKART1 commented on August 16, 2024

It is already in jitpack:
image

What about pom.xml - there are different approaches but as for me the best way is to keep current version + SNAPSHOT string inside pom.xml

from jadb.

vidstige avatar vidstige commented on August 16, 2024

Alright, cool, thanks. With "current", you mean the last released version or the version currently in the making? Are we good to go for now, in that case? Or should we go "1.2-SNAPSHOT"?

from jadb.

SKART1 avatar SKART1 commented on August 16, 2024

I mean "the last released version" - but it is my IMHO based on discussions of pro and con of both approaches

from jadb.

vidstige avatar vidstige commented on August 16, 2024

Alright. I've also heard sensible arguments for going with with the upcoming version, but lets go with this for now. Thanks for the initiative and help guys.

from jadb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.