base_trainer._save_checkpoint error in Windows about pytorch-template HOT 3 CLOSED

Hi @victoresque ,

I believe this issue is solved with the one change I mention in my post. At least, it then runs nicely in Windows. I have not verified that the behavior is equivalent in Linux/MacOS, but it should be (based on the 'os' module documentation).

Do you agree with making this change?

from pytorch-template.

Sure, I overlooked the change, thanks for noticing

from pytorch-template.

Hi,

The issue should not be closed before the code is updated.

The following change to line 115 in /base/base_trainer.py is required:

From:

os.rename(filename, os.path.join(self.checkpoint_dir, 'model_best.pth.tar'))

To:

os.replace(filename, os.path.join(self.checkpoint_dir, 'model_best.pth.tar'))

from pytorch-template.