Giter Club home page Giter Club logo

Comments (7)

dasois avatar dasois commented on May 28, 2024

this will fix #28 and #33

from ngprogress.

gngeorgiev avatar gngeorgiev commented on May 28, 2024

Are you referring to setting it with inline style(probably using the color method) or with external style?

from ngprogress.

dasois avatar dasois commented on May 28, 2024

Im talking about changing the color property in the external css file.

from ngprogress.

gngeorgiev avatar gngeorgiev commented on May 28, 2024

Well since the colors are applied using inline styles, css ones will not work. It should be considered to use only one of both. I would go for inline styles only, this will also allow to implement multiple progressbars in future as per #37. I cannot agree with #33 since it conflicts with the other two.

That's just how I see it

from ngprogress.

dasois avatar dasois commented on May 28, 2024

I have thought about that for a while. I think another solution, which is maybe serving both purposes, would be to define a mandatory css-suffix attribute on the directive, which you'll have to apply to your css-class in order to get the styling.
What do you think about that?

from ngprogress.

gngeorgiev avatar gngeorgiev commented on May 28, 2024

Okay, here's an idea I just got out of the blue, it's just an idea, but we can use ShadowDom - https://github.com/Polymer/ShadowDOM. Every progress bar will have its own shadow dom, where the styles will use the same classes/ids (will be kept in a <style> tag) and whenever a value changes the shadowdom will be recompiled. Not sure whether this will work or not, but can be worth the try. Instead of including the stylesheet the user will include shadowdom.

from ngprogress.

cetra3 avatar cetra3 commented on May 28, 2024

Closing this as a duplicate of #33

from ngprogress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.