Giter Club home page Giter Club logo

Comments (2)

mikelow avatar mikelow commented on June 26, 2024

Thanks for the detailed report. I'll take a look when I have the chance. I think you might already understand this, but Sustain Rate isn't a concept in SF2 and DLS. As a workaround, the PSX ADSR conversion code (which is over 15 years old and not the greatest), checks if the decay stage is effectively unused, and if so, attempts to implement the sustain rate using decay (but only if the sustain rate is a negative value - yes it can increase amplitude as well). At any rate, this is very possibly what you're seeing here, and yeah it's probably buggy even for what it's attempting to do. But bear in mind that SF2 and DLS can't represent the PSX SPU envelope entirely accurately.

from vgmtrans.

jdperos avatar jdperos commented on June 26, 2024

@mikelow thanks for the response and the informative explanations! Yes, I'm vaguely aware of the envelope parameters that the PSX SPU has to offer, and that it definitely has more than the basic ADSR parameters that SF2 has to offer. So what I would hope would occur on SF2 export would be an approximation of what the instruments are doing on the SPU, rather than something exact. Unfortunately, I can't find much documentation on the Akao instrument format to get more information about what the above bytes corresponding with ADSR parameters correspond to in terms of seconds - however in its current implementation, every ADSR acts essentially as a gate, so instruments that have looping samples and rely on decays (like guitars and harps) are rough.

from vgmtrans.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.