Giter Club home page Giter Club logo

Comments (2)

alexrp avatar alexrp commented on August 22, 2024

Somewhat related: LeadingTrivia and TrailingTrivia on SyntaxToken should probably be changed to SyntaxItemList<SyntaxTrivia>.

from celerity.

alexrp avatar alexrp commented on August 22, 2024

This begs the question, though: Should we also expose GetText() and GetFullText()? That would require a Parent property. But then that might signal that the list is a node in the tree, which is not actually the case. We'd then also have to consider tree traversal methods, at which point these lists start to look an awful lot like SyntaxItems in their own right...

Decision: Tree property, Parent property, Span/FullSpan properties, ToString()/ToFullString() methods, GetText()/GetFullText() methods. No tree traversal methods. In the future, we could consider extracting these into an interface if there's a use case for that.

(I think this will also allow us to reduce the amount of SetParent() calls we emit in generated node classes.)

from celerity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.