fix: resolving dependencies takes a relatively long time about very_good_workflows HOT 2 CLOSED

Hi @orestesgaolin 👋
Thanks for opening an issue!

We'll take a look shortly and see what we can do to improve the dependency installation step. I think it makes sense to cache the installed dependencies and we can probably use the pubspec.lock to invalidate the cache -- thanks for bringing this up!

from very_good_workflows.

Hello everybody. I spent some time looking into this.

Seems like the flutter action takes care of caching everything under ./pub-cache, the problem is that the cache key never considers anything except the flutter version/arch/channel as keys. Subsequent changes on .pub_cache won't be saved to the cache.

We can fix that by providing a custom cache key with a hash to all lock files in the repo. But that will take no effect if the repo has all lock files ignored.

One idea I had was that once the first very_good packages get is run for the top package (app), then all the subsequent runs could use --offline flag to not refetch dependencies via network.

That would be risky and would break in most cases. In a scenario where the cache was mistakenly hit, any new dependencies would break the workflow, and since sub-packages tend to be libraries, their lock is almost always ignored. We cannot rely on the main apps lock since dev dependencies on the sub-packages will not be declared as transitive dependencies on the main apps lock.

An alternative is to consider the pubspec.yaml files as cache breakers.

So here is my proposal:

• Pass cache-key: flutter-:os:-:channel:-:version:-:arch:-:hash:-${{ hashFiles('**/pubspec.yaml') }} to the flutter action.
• Include an option to override that key for very good workflow users.
• Propose the addition of an option to pass "restore-keys" to flutter actions which then would be passed to the cache action. Here: subosito/flutter-action#195

from very_good_workflows.