Giter Club home page Giter Club logo

Comments (5)

beckje01 avatar beckje01 commented on May 26, 2024

To support OAuth the Resource Server side of things should vertx-auth-service have an api added or extend AuthService to log a user in with just a bearer token? Or should we use the existing api somehow?

from vertx-web.

cescoffier avatar cescoffier commented on May 26, 2024

@pmlopes Do we postpone it to 3.2.0 ? ( I didn't follow the progress, so maybe it's fixed)

from vertx-web.

pmlopes avatar pmlopes commented on May 26, 2024

we postpone because @millross plan is to complete the implementation of vertx3 pac4j and then finish the fully async only OAuth support. (pac4j does way more stuff than just oauth but parts of its API are blocking so he is busy trying to convert some things to async and run other in a worker thread...)

from vertx-web.

millross avatar millross commented on May 26, 2024

Agree with this postponement. Just as an FYI Jérôme (pac4j) has an aspiration to make pac4j optionally non-blocking in future (by offering a non-blocking API and also a plugin client implementation for http requests based on the clients used by the various non-blocking implementations, ie we would offer a vert.x http implementation, for example, as part of the vert.x-pac4j implementation). Depending on what this looks like when we get cracking on it, this may offer a better solution than my vertx-oauth implementation.

I might also look at whether, if that's not viable straightforwardly, separating out some more pac4j stuff so that it can be used conveniently by my OAuth2 implementation, which means every time pac4j add support for a new OAuth2 provider, we can reuse it in the non-blocking implementation, so only the raw "OAuth2" workflow is implemented, and then uses Pac4j configuration for the rest of it. However, that's rather thinking aloud.

from vertx-web.

cescoffier avatar cescoffier commented on May 26, 2024

See https://github.com/vert-x3/vertx-auth/issues/39

from vertx-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.