Giter Club home page Giter Club logo

Comments (6)

thysultan avatar thysultan commented on May 12, 2024 1

originally comments where not handled property there where edge cases that escaped, though upstream they are handled well.

from styled-jsx.

giuseppeg avatar giuseppeg commented on May 12, 2024

@rauchg fixing the comments should be trivial, do you want to preserve or strip them out?
The second case is tricker. Does it break when there are properties with multiple values separated by comma like box-shadow: 0 0 10px black, inset 0 0 5px black ?

from styled-jsx.

rauchg avatar rauchg commented on May 12, 2024
  • I think we should strip / minify as much as possible, since this is the compilation step
  • I mean for selectors. Reading the code I realized this is too naive, and @thysultan has already addressed it upstream if you need inspiration

from styled-jsx.

giuseppeg avatar giuseppeg commented on May 12, 2024

Adding one more here – the :root selector shouldn't be namespaced cc @nkzawa

from styled-jsx.

rauchg avatar rauchg commented on May 12, 2024

+1

from styled-jsx.

giuseppeg avatar giuseppeg commented on May 12, 2024

fixed by #134

from styled-jsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.