Comments (2)
I believe that's correct behavior, at least it's something that we wanted for the applications where we use the rate limiter, that are usually very long running tasks.
For downloading/uploading files I would recommend to use the semaphore primitive directly because what you usually want to do is to download/upload n files concurrently all the time, without pauses or gaps.
const s = new Sema(2);
await Promise.all(
images.map(async (image, index) => {
await s.acquire();
const parsed = await _prepImage.call(this, image);
await util.downloadImage(parsed.url, parsed.target);
s.release();
})
);
or more correctly if you want to keep s
global and never leak the tokens, then you should use
try {
await s.acquire();
...
} catch (err)
...
} finally {
s.release();
}
from async-sema.
Awesome! Thank you so much @OlliV, that should do the trick for me.
I really appreciate your help!
from async-sema.
Related Issues (17)
- Possible p() & v() confusion HOT 2
- broken typescript definition HOT 3
- Action required: Greenkeeper could not be activated 🚨
- Add examples to README
- Make it OSS
- Intuition surrounding `nr` values
- Way to cancel pending tokens HOT 3
- .release() does not check actual token count HOT 3
- Some nice way of async iterating? HOT 6
- IE 11 Support HOT 3
- Args object should be optional
- Add Sema.run utility for easy task processing
- RateLimit does not work with number less than 1. HOT 2
- Uncaught TypeError: Class extends value #<Object> is not a constructor or null HOT 1
- Is it possible to make 1 request every 2 seconds? HOT 1
- What is the `nr` variable? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-sema.