Giter Club home page Giter Club logo

Comments (3)

veniosg avatar veniosg commented on August 20, 2024

I'm afraid I'm going to disappoint you on this issue. Specifically:

Increasing height of cover (background image) in navigation drawer
Appearance of bookmarks

For these two, I've replied in #45.

Material style icon for New(Plus) and Edit(Pencil)

I'm assuming you're referring to the Floating Action Button. According to the Material design guidelines, "A floating action button represents the primary action in an application". Dir being a file manager, there is no inherent primary action (or at least it's not "Create directory"). The Pencil/operations action could be a candidate but I'm afraid it'll make for a unnecessarily separated set of actions. I've actually been thinking about completely disbanding the operations "group" and having them on the top level when long pressing, as quite a few users have had trouble finding these; making it a FAB will make that transition even harder.

Adding an option to create a file alongside the option to create folder

I was actually thinking about doing this during the Material redesign, but even if there's a "create file" action, it's not apparent what type that file should be. Given the options, I opted to not add it at all to avoid having a half-baked implementation and UX. (FWIW, given the time constraints, the options where either creating only text files, which would probably also need a text editor implementation, or allowing any filetype but being unable to edit almost all of them in-app).

As a side note, (and this is the case both for the FAB and the nav drawer), many apps try to fit these patterns everywhere, sometimes worsening the UX, just because they feel it's a must-have for Material design apps. In designing Dir I've deliberately avoided using standard components that make no sense for the app's purpose and use case only to make Dir feel more "standard". Hence the lack of some ubiquitous components/patterns :)

Hope this makes sense,
George.

from dir.

SanmayJoshi avatar SanmayJoshi commented on August 20, 2024

Hey George,

It's very nice to have well reasoned reply from you. Thanks for that.

I don't mean to be persistent here, but think I need to clarify some issues listed above, that I think, I didn't explain well.

Appearance of bookmarks

I think one may want to name a bookmark something different than the original name of the folder. So, maybe it might be that bookmarks and their original folder could be discriminated. This is also the reason I mentioned making bookmarks look similar to other fragments in nav drawer.

Adding an option to create a file alongside the option to create folder

By allowing users to create new file, I meant to allow them to create any kind of new file. When a user shall type name for that file, the user would type the name with extension, which is how the file type shall be determined. Many apps do similar, I guess.

All other issues mentioned above are perfectly handled by you. Thanks for such a well thought reply.

from dir.

veniosg avatar veniosg commented on August 20, 2024

No worries, thanks for the update.

About the bookmarks, what do you mean by making them look similar to other fragments? They're actually using the same code behind the scenes at the moment. In regards to renaming them, this actually could be done fairly easily using the current interface and code.

In regards to the file creation option, I haven't used other file managers for a long time ago. Would you happen to know how the most popular ones handle this? If it turns out that enough popular ones do it that it's expected, I would be up for adding this generic "create file" option, and let opening the file worry the apps we delegate to.

from dir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.