velvetorg / velvet.js Goto Github PK

The .clone() function for anything that inherits from Base does not work as expected on the scenegraph. Although is will work for the most part it will not clone children of children.

In order to use the addComponent function, that function need to chack that the parameter passed is a valid component (not just a random type like string).

Someone figure out how to do this:

this.addComponent = function(componentInstance)
    {
        //Check that it is a valid componenet
        //e.g. renderer
        //--> How would I do this <--

        //Add to list
        this.components.push(componentInstance);
    }

When modifying transform.position, transform.scale, transform.localPosition and transform.localScale then the scenegraph will not update.

Read more about the specifics here: http://stackoverflow.com/questions/40991821/typescript-setter-is-not-called-on-a-sub-property-of-a-class-instance/40992866?noredirect=1#comment69207842_40992866

Example that may cause the problem:

player.transform.position = new Vector2(10, 10); //Okay
player.transform.position.x = 10; //This will not update the scene graph and may cause problems

A warning has been added to the vector class - but this is a temporary solution