Giter Club home page Giter Club logo

Comments (8)

domoritz avatar domoritz commented on July 18, 2024

You can try to step through the code. I have a script endpoint where you can add breakpoints and look at the variables at the point of the error.

from ts-json-schema-generator.

MarcusRiemer avatar MarcusRiemer commented on July 18, 2024

I will see whether I can dig something up that way. But it seems that I am at least not stumbling over a known limitation?

from ts-json-schema-generator.

domoritz avatar domoritz commented on July 18, 2024

Mapped types are tricky and we recently added some more support for it but it's certainly not complete.

from ts-json-schema-generator.

MarcusRiemer avatar MarcusRiemer commented on July 18, 2024

Huh, interestingly the current state in master does not crash. So apparently something in this changeset has fixed the problem.

And from the looks of it the resulting schema is perfectly fine:

{
  "$ref": "#/definitions/RefTestInterface",
  "$schema": "http://json-schema.org/draft-06/schema#",
  "definitions": {
    "ParameterReference": {
      "additionalProperties": false,
      "properties": {
        "$ref": {
          "type": "string"
        }
      },
      "required": [
        "$ref"
      ],
      "type": "object"
    },
    "ParameterReferenceable<TestInterface>": {
      "additionalProperties": false,
      "properties": {
        "myNum": {
          "anyOf": [
            {
              "type": "number"
            },
            {
              "$ref": "#/definitions/ParameterReference"
            }
          ]
        },
        "myStr": {
          "anyOf": [
            {
              "type": "string"
            },
            {
              "$ref": "#/definitions/ParameterReference"
            }
          ]
        }
      },
      "type": "object"
    },
    "RefTestInterface": {
      "$ref": "#/definitions/ParameterReferenceable<TestInterface>"
    }
  }
}

Would you be interested in a PR with this exact testcase?

from ts-json-schema-generator.

MarcusRiemer avatar MarcusRiemer commented on July 18, 2024

Oh, and I would really appreciate a version bump with the current master. Would you be able to do this in a timely manner? In that case I wouldn't have to roll out a package.json with a git-package.

from ts-json-schema-generator.

MarcusRiemer avatar MarcusRiemer commented on July 18, 2024

Sorry for making such a series of live updates here, I am literally letting you know what happens as I discover it. Right now I had at least two validators stumble over "#/definitions/ParameterReferenceable<TestInterface>" because < and > are not allowed to appear unescaped in an URL. So these would require escaping.

from ts-json-schema-generator.

domoritz avatar domoritz commented on July 18, 2024

Oh, I didn't know it wasn't released. I'll do that soon.

from ts-json-schema-generator.

domoritz avatar domoritz commented on July 18, 2024

Done in 0.30

from ts-json-schema-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.