<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

It works for me <div class="highlight highlight-source-ts notranslate position-rel

<div class="highlight highlight-source-ts notranslate position-relative overflow-auto" dir="auto" da

Incorrect output for Generic with UnionType about ts-json-schema-generator HOT 4 CLOSED

vega commented on July 18, 2024

Incorrect output for Generic with UnionType

from ts-json-schema-generator.

Comments (4)

domoritz commented on July 18, 2024

It works for me

export interface LogicalOperand<T> {
    foo: T;
}

export type Condition<T> = {
  selection: LogicalOperand<string>;
} & T;

export interface MyObject {
    bar: number;
}

export type MyType = Condition<MyObject>;

{
  "$ref": "#/definitions/MyType",
  "$schema": "http://json-schema.org/draft-04/schema#",
  "definitions": {
    "Condition<MyObject>": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "selection": {
          "$ref": "#/definitions/LogicalOperand<string>"
        }
      },
      "required": [
        "bar",
        "selection"
      ],
      "type": "object"
    },
    "LogicalOperand<string>": {
      "additionalProperties": false,
      "properties": {
        "foo": {
          "type": "string"
        }
      },
      "required": [
        "foo"
      ],
      "type": "object"
    },
    "MyObject": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        }
      },
      "required": [
        "bar"
      ],
      "type": "object"
    },
    "MyType": {
      "$ref": "#/definitions/Condition<MyObject>"
    }
  }
}

from ts-json-schema-generator.

kanitw commented on July 18, 2024

export type MyType = Condition;

This doesn't have a union type inside Condition.

Try export type MyType = Condition<MyObject|TheirObject>; ?

from ts-json-schema-generator.

domoritz commented on July 18, 2024

export type Condition<T> = {
  selection: T;
};

export interface A {
    foo: number;
    bar: number;
}

export interface B {
    bar: number;
    baz: number;
}

export type MyType = Condition<A | B>;

{
  "$ref": "#/definitions/MyType",
  "$schema": "http://json-schema.org/draft-04/schema#",
  "definitions": {
    "A": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "foo": {
          "type": "number"
        }
      },
      "required": [
        "foo",
        "bar"
      ],
      "type": "object"
    },
    "B": {
      "additionalProperties": false,
      "properties": {
        "bar": {
          "type": "number"
        },
        "baz": {
          "type": "number"
        }
      },
      "required": [
        "bar",
        "baz"
      ],
      "type": "object"
    },
    "Condition<(A|B)>": {
      "additionalProperties": false,
      "properties": {
        "selection": {
          "anyOf": [
            {
              "$ref": "#/definitions/A"
            },
            {
              "$ref": "#/definitions/B"
            }
          ]
        }
      },
      "required": [
        "selection"
      ],
      "type": "object"
    },
    "MyType": {
      "$ref": "#/definitions/Condition<(A|B)>"
    }
  }
}