Giter Club home page Giter Club logo

Comments (9)

domoritz avatar domoritz commented on July 19, 2024 1

I think it makes sense that you get the /// ... ref import when you have a type only import. That's probably what's going on so I think we should make ts-expose-internals a dependency or remove it from the package.

from ts-json-schema-generator.

arthurfiorette avatar arthurfiorette commented on July 19, 2024

Where is this error being thrown?

This is probably because you have "skipLibCheck": false in your tsconfig, is there a reason for also type checking your dependencies?

from ts-json-schema-generator.

domoritz avatar domoritz commented on July 19, 2024

Dependencies should type check if possible.

from ts-json-schema-generator.

arthurfiorette avatar arthurfiorette commented on July 19, 2024

Hmm, somehow tsc is adding this directive on every dts file emitted...

image

Have to say, never saw something like this before, I cannot even find documentation about it.

from ts-json-schema-generator.

arthurfiorette avatar arthurfiorette commented on July 19, 2024

I think typescript is adding this triple slash directive every time ts is imported/used. As the ts-expose-internals library extends the typescript namespace, it thinks without this definition some code would be invalid (which is incorrect).

We could simply add ts-expose-internals as a dependency, but this would fuck up every library that uses this package by also having the extended types for them.

I'm currently looking up for a solution but this is an undocumented behavior of typescript. Probably having to disable type check or manually removing these /// ... references are the solution here....

from ts-json-schema-generator.

sebbi08 avatar sebbi08 commented on July 19, 2024

Hi i have seen that in some files the import of typescript got changed from import ts from "typescript"; to import type ts from "typescript"; might this be the problem ?

from ts-json-schema-generator.

arthurfiorette avatar arthurfiorette commented on July 19, 2024

I don't think so, import type is just a way to say that all imports are only used in the type land and aren't present in the final js code.

from ts-json-schema-generator.

sebbi08 avatar sebbi08 commented on July 19, 2024

HI yes that fixed the problem thanks for the quick solution

from ts-json-schema-generator.

github-actions avatar github-actions commented on July 19, 2024

🚀 Issue was released in v2.3.0 🚀

from ts-json-schema-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.