Giter Club home page Giter Club logo

Comments (3)

amrit110 avatar amrit110 commented on June 8, 2024 1

@fcogidi, @a-kore I've created PRs #389 and #390 to fix mypy errors for the evaluate and monitor packages respectively. This is not high priority and can be done when you get time, especially i would recommend doing this once the package is refactored and we have the demos using the APIs more mature. But opening it now, so we can slowly fix the type hints and improve the codebase.

from cyclops.

emersodb avatar emersodb commented on June 8, 2024

As a possible approach for this, you might consider looking at the PR here. You don't need to worry about most of the files there, but the following are likely relevant:
.pre-commit-config.yaml
run_mypy.sh
mypy.ini
pyproject.toml
I put some comments around these changes in the PR, but the gist is that running mypy . is significantly more strict than running the mypy checks through pre-commit run --all-files because pre-commit is run in an isolated environment, which changes the way types are interpreted etc. So we need to put

entry: ./run_mypy.sh
language: system```

into our pre-commit so that it runs in the system's currently activated env. We also want to manipulate the entry point to run a script so that the mypy.ini settings are explicitly brought into the pre-commit run.

from cyclops.

fcogidi avatar fcogidi commented on June 8, 2024

PR #389 done.

from cyclops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.