Comments (3)
@fcogidi, @a-kore I've created PRs #389 and #390 to fix mypy errors for the evaluate and monitor packages respectively. This is not high priority and can be done when you get time, especially i would recommend doing this once the package is refactored and we have the demos using the APIs more mature. But opening it now, so we can slowly fix the type hints and improve the codebase.
from cyclops.
As a possible approach for this, you might consider looking at the PR here. You don't need to worry about most of the files there, but the following are likely relevant:
.pre-commit-config.yaml
run_mypy.sh
mypy.ini
pyproject.toml
I put some comments around these changes in the PR, but the gist is that running mypy .
is significantly more strict than running the mypy checks through pre-commit run --all-files
because pre-commit is run in an isolated environment, which changes the way types are interpreted etc. So we need to put
entry: ./run_mypy.sh
language: system```
into our pre-commit so that it runs in the system's currently activated env. We also want to manipulate the entry point to run a script so that the mypy.ini settings are explicitly brought into the pre-commit run.
from cyclops.
PR #389 done.
from cyclops.
Related Issues (20)
- Dynamically offer every method and attribute of the PyTorch model in the PTModel wrapper
- query dataset APIs design review
- Add support for using the query op Apply with multiple column inputs
- Documentation build fails for evaluate package HOT 3
- Improve API documentation
- Code style check
- Add unit tests for utils module in data subpackage HOT 1
- Add default model params, allow override by specifying config
- Unknown type for targets and preds HOT 2
- Development Roadmap HOT 3
- Logging model parameters to report only captures string values HOT 3
- Improve fairness metrics visualization using scatter plot
- Add SQL OR, LIKE and IN to Query API
- Cyclops installation fails in Windows HOT 2
- Importing Cyclops in Kaggle Notebooks fails HOT 1
- Runway Plots HOT 4
- Refactor: Use `namedtuple` instead of `tuple` in `ClassificationPlotter`
- Calibration Plots
- Refactor `create_metric_cards` in `report.utils`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cyclops.