Removal is not thread safe about mpb HOT 7 CLOSED

Note adding wait groups makes no difference.

from mpb.

It just happens that RemoveBar method never considered "remove after completion done" case, there is nothing to do with thread safety. In fact it is removing the bar from the heap container, but too late in this particular case. It's very tricky to keep track, if initial intention (remove or keep) is unknown. So I would better rename this method to something like RemoveWhile and better add an option to auto-remove bar after completion. This way, there is no need to call defer p.RemoveBar.

from mpb.

Is there a way to set the initial intention? ie. remove on completion.

from mpb.

Not yet, but I'm going to add via optional BarOption.
User api would be: p.AddBar(total, mpb.BarRemoveOnComplete()). As for current p.RemoveBar, I'm going to rename it to p.Abort, because imo it would be clear indication what the method does.

from mpb.

I did some refactoring, so following code should work as you wish.

const sleep = 100 * time.Millisecond

func main() {
	p := mpb.New()
	
	b1 := p.AddBar(int64(100), mpb.BarRemoveOnComplete(),
			mpb.PrependDecorators(decor.StaticName("bar1", 0, 0)))
			
	go func() {
		go func() {
			time.Sleep(10 * sleep)
			b2 := p.AddBar(int64(100), mpb.BarRemoveOnComplete(),
					mpb.PrependDecorators(decor.StaticName("bar2", 0, 0)))
					
			for !b2.Completed() {
				b2.IncrBy(10) // fastest
				time.Sleep(sleep)
			}
		}()

		for !b1.Completed() {
			b1.IncrBy(2) // second fastest
			time.Sleep(sleep)
		}
	}()

	go func() {
		b3 := p.AddBar(int64(100), mpb.BarRemoveOnComplete(),
				mpb.PrependDecorators(decor.StaticName("bar3", 0, 0)))
				
		for !b3.Completed() {
			b3.IncrBy(1) // slowest
			time.Sleep(sleep)
		}
	}()

	p.Wait()
}

from mpb.

Thanks @vbauerster! I'll give this a go next Monday-ish.

from mpb.

Tried it today, seems to be working well! I noticed some slight glitches when firing progressbars that are then quickly removed, but I'll try to come up with a test case for that and report it separately.

from mpb.