Unicode characters with bytes greater than 127 cause crash about mysql-kit HOT 4 CLOSED

If you could submit a test case where this fails, that would help a ton.

Otherwise I will investigate this on the next update.

from mysql-kit.

Here's how to reproduce the issue:

let mysql = try! MySQL.Database(...)
let myString = "È" // Unicode #200
try! mysql.execute("INSERT INTO mytable (myfield) VALUES (?)", [.string(myString)], nil)

This crashes at the following line in Bind.swift:

buffer[i] = Char(byte)

Because it's attempting to cast a decimal value of 200 into an Int8.

from mysql-kit.

UPDATE: Sorry to keep pestering about this, but I believe it's a big flaw in this library that should be addressed. I had a little more time to dig into it today, and I believe that the solution is simple.

I believe that Char should be changed to be a typealias for UInt8. The utf8 property of Swift's String returns a UTF8View, which itself is an array of unsigned 8-bit integers. The documentation isn't clear about this, but after some experimentation I've come to the conclusion that the integers are indeed unsigned, which is why we were experiencing crashes when handling any Unicode characters containing a byte larger than 127.

Making this change allows the package to be fully compatible with all Unicode characters.

from mysql-kit.

Fixed with PR #27

from mysql-kit.