Math-DS dependency about sparse-octree HOT 3 CLOSED

Hi ahmadsholehin,

I've moved the math code from three into math-ds to reduce the bundle size for projects that don't use three.

The real problem lies with the tree-shaking implementation of popular bundlers. Unfortunately, all of them are rather conservative in that aspect and don't actually remove a lot of unused code. If tree-shaking worked flawlessly, depending on three would be an option. But even then, the math code from three should reside in a separate module to speed up the bundling process. Code analysis takes a while and three is big.

The sparse-octree library only uses Box3, Ray and Vector3 from math-ds and yet all the other unrelated classes get included in the final bundle for no reason. That's still much less unused code compared to using three as a dependency in projects that don't use three. When I created sparse-octree for one of my projects, it did rely on the math classes from three. But then my bundles all included a stupid amount of unused classes from three. The compromise was to use a dedicated math module.

I'm keeping an eye on the bundling output, but nothing has changed in the past years.

from sparse-octree.

I'm keeping an eye on the bundling output, but nothing has changed in the past years.

After looking into the build setup again, I found out that rollup-plugin-babel is breaking the tree-shaking. I've changed the setup in 9f1d286 and now the unrelated classes are gone from the final bundle.

So if your build setup is configured correcty, the actual footprint of the math-ds dependency will be very small.

from sparse-octree.

Closing due to inactivity.

from sparse-octree.