Giter Club home page Giter Club logo

Comments (24)

adrian-bl avatar adrian-bl commented on July 4, 2024

closing as WONTFIX: The short pause-on-notification is intentional.

The OsmAnd issue is a feature/bug of OsmAnd: It probably broadcasts an event that causes the mediaplayer to stop. (As it expects to 'take over' the audio channel)

from vanilla.

breversa avatar breversa commented on July 4, 2024

Why not make it optional then, with the current behaviour as default ?

Thanks for the info regarding OsmAnd : indeed, the app can use the notification, music, or call channel to give directions (I use music). Weird that music does not resume afterwards though. I'll try and get in touch with the devs.

from vanilla.

breversa avatar breversa commented on July 4, 2024

After some more testing, I've found that Vanilla Player and OsmAnd do sometimes work properly with each other.

The following sometimes works :
1- Start navigating with OsmAnd until you hear a direction instruction
2- Start playing music with Vanilla Player
3- Get back to OsmAnd
4- Wait for another direction instruction to be spoken
5- Music stops
6- Direction instruction is spoken
7- Music resumes ! :D

from vanilla.

MauroMombelli avatar MauroMombelli commented on July 4, 2024

please, reopen the issue and give us a flag to choose this beaviour.
It is really irritating, if you are chatting in 2 different program it is imposible to listen to music, also some program like watsapp bypass the "stop" (and i like it to do so, even if i'm aware it should not do that)

from vanilla.

breversa avatar breversa commented on July 4, 2024

Yeah, I'm really tempted to switch again to DeaDBeeF or any other music player because of that. :-(

I fully understand the use of that feature, but please… make it optional. :-)

from vanilla.

dalb8 avatar dalb8 commented on July 4, 2024

Perhaps you can try this app to change the default behaviour: https://github.com/TrentPierce/DontPause.

from vanilla.

adrian-bl avatar adrian-bl commented on July 4, 2024

Ok, i will have a look at this if there is such a huge demand for the feature :-)

So what should the desired behaviour be?

a) Simply ignore notifications/other apps and keep playing until the user hits stop/pause

b) Resume playback in any case, even if the other app requested the audio channel for an extended amount of time (eg: listening to music -> open youtube -> close youtube -> vanilla resumes)

from vanilla.

breversa avatar breversa commented on July 4, 2024

Juhu, prima ! Vielen Dank Adrian ! :D
(Yeah, given your surname, I decided you must speak german. My bad if you don't, but a big THANK YOU anyway ! ;-) )

My desired behaviour is as stated in my opening post :

1- Keep playing during notifications (i.e. don't do anything special)

Or, my best choice :

2- Lower music volume during notification. I believe the default Android 2.3 music player had such an option, and I found it pretty nifty (called "volume ducking", IIRC).

Volume ducking reduces the volume by x dB or y%, but I can't remember precisely. Maybe -3 dB ?

Clementine Remote Control (https://code.google.com/p/clementine-remote-android/) has a similar nifty feature, which detects incoming calls (on the phone where it's installed) and reduces the volume on the PC (where Clementine plays) so you can hear the ringtone just fine.

from vanilla.

dalb8 avatar dalb8 commented on July 4, 2024

You could have an option in the headphone detector app to put the device in vibrate mode.

from vanilla.

MauroMombelli avatar MauroMombelli commented on July 4, 2024

IMHO if notification user may choose from "stop", "duck %" and "vibrate",
or maybe just a %; if 100 the music wont be affected, phone will vibrate
depending on the specific notification settig; if 0% it will stop.
if prolungate i think "just stop" and "stop and resume" are fine.

@dalb8: what if you use bluethoot with car? what if you plug in
headphone+mic for "normal" usage? why use an hack when the andorid's audio
API has been written to work out this problem?

2014-07-08 12:08 GMT+02:00 dalb8 [email protected]:

You could have an option in the headphone detector app to put the device
in vibrate mode.


Reply to this email directly or view it on GitHub
https://github.com/adrian-bl/vanilla/issues/45#issuecomment-48305809.

from vanilla.

dandv avatar dandv commented on July 4, 2024

+1 for optionally lowering volume during notifications. It's a setting I've seen in other players.

from vanilla.

dalb8 avatar dalb8 commented on July 4, 2024

I just installed Osmand 1.8.0 and it has a preference for interrupting music.

from vanilla.

breversa avatar breversa commented on July 4, 2024

Thanks for the heads-up, dalb8 : I installed OsmAnd 1.8 and gave this option a try.

It works rather well, however sometimes the music either interrupts with a delay, doesn't interrupt, or does not resume after interruption, though I really can't tell whether it's OsmAnd or Vanilla acting up.

My guess is that Vanilla's and OsmAnd's music interruptions sometimes conflit with each other.

IMO, as stated above, I don't expect a music player to stop playing music during a notification, but I appreciate if a navigation app did it. :-)

from vanilla.

breversa avatar breversa commented on July 4, 2024

Oops ! I closed that issue by mistake !

from vanilla.

adrian-bl avatar adrian-bl commented on July 4, 2024

-> Closing all open bugs as vanilla was removed from the play store by some DMCA-Troll, see: https://plus.google.com/115564237657785223556/posts/TvY1PD4ci2N

from vanilla.

dandv avatar dandv commented on July 4, 2024

All, there is hope. I work at Google and have filed an internal ticket to review this bogus DMCA takedown.

from vanilla.

MauroMombelli avatar MauroMombelli commented on July 4, 2024

Good for vanilla, but as Italian I can recognize the pattern of "friend of
friend" witch lead to close an ecosystem, and then slowly degrade to
corruption.
Just my 5 cents.

Il giorno ven 12 dic 2014 20:55 Dan Dascalescu [email protected]
ha scritto:

All, there is hope. I work at Google and have filed an internal ticket to
review this bogus DMCA takedown.


Reply to this email directly or view it on GitHub
https://github.com/adrian-bl/vanilla/issues/45#issuecomment-66825773.

from vanilla.

dandv avatar dandv commented on July 4, 2024

@MauroMombelli: This is not nepotism, it's networking :) (I'm from Romania, so I know what you're talking about).

More precisely, Adrian worked hard on a valuable product, and I'm doing what I can to help. He deserves it because he was unjustly wronged by this fake DMCA takedown. #justice

from vanilla.

breversa avatar breversa commented on July 4, 2024

So… er… any chance to see that issue corrected ? ;-)

from vanilla.

Allanitomwesh avatar Allanitomwesh commented on July 4, 2024

I think it would be best if

  1. instead of stopping playback,it reduced the volume and the notification played over the song. some other players do this.
  2. Implement b) suggestion "resume playback in any case"

that should solve this.

from vanilla.

breversa avatar breversa commented on July 4, 2024

Yes, that's precisely what I suggested above.

Glad to see I'm not the only one looking forward to that feature ! :-)

from vanilla.

adrian-bl avatar adrian-bl commented on July 4, 2024

Closing as fixed: PR was merged

from vanilla.

ToNIX- avatar ToNIX- commented on July 4, 2024

Just a little update, works flawlessly on my Moto G XT1040 with Vanilla 1.0.32, tested with Nokia Here Maps giving GPS directions. I think that the initial 50% is too high (it should be at 25%), but all in all, an amazing addition!

from vanilla.

breversa avatar breversa commented on July 4, 2024

Glad to see you too love that feature I've been longing for ! ;-)

Why not add it to the application features here : https://github.com/vanilla-music/vanilla ?

from vanilla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.