Simultaneous accesses crash about swiftcbor HOT 4 CLOSED

Never tried Swift 4, I don't even have a working Swift compiler anywhere currently… Do you have any idea what might be happening here?

I found this: https://bugs.swift.org/browse/SR-5119 — could that be the issue?

from swiftcbor.

I think it's because the istream gets modified while we parse through the CBOR. I think if it was immutable and just iterated over there wouldn't be a problem. Not sure if there's an easy way todo this.

from swiftcbor.

I have a fix for this. You can have a look here:

daijo@c259b81

I had to make the stream immutable and pass it along in the recursion. I'm not sure it would make a good pull request since I think the memory performance might not be good enough for general use. It will probably be good enough in our application since we have an upper limit on the size of the CBOR.

In any case I need to tidy up a little.

Have a look!

from swiftcbor.

I just made a pull request for the same issue, you can fix the issue by moving the two popByte calls to separate lines in the code (see #9).

from swiftcbor.