Giter Club home page Giter Club logo

Comments (6)

Pokom avatar Pokom commented on September 2, 2024 3

@wilfredmifsud

It might be worthwhile to consider adding some of these items to the README.md. As awkward as this is to say, it wasn't obvious to me that FontAwesome and Bootstrap we're required to get this to work.

from ng2-table.

wilfredmifsud avatar wilfredmifsud commented on September 2, 2024 2

Do you have FontAwesome installed ? As it renders an icon in the th when you sort up/ down (there is no icon when not sorting)

from ng2-table.

georgeedwards avatar georgeedwards commented on September 2, 2024 2

Was going to open a new issue/feature request, but it seems like this only works with font-awesome, and the generated icon can't be configured - am I right? If so, I think this would be a really useful feature, to avoid the dependency on bootstrap and font-awesome. I for example, would like the icons to be generated as <i class="material-icons">arrow_drop_down</i> and <i class="material-icons">arrow_drop_up</i> so I can use Google Icons which I use across my project already.

from ng2-table.

jeff-jacobs avatar jeff-jacobs commented on September 2, 2024 1

I am going to also say the ability to configure the sort icon is kind of a must. I shouldn't have to load the entire font-awesome file just for a couple icons. I built my own font icon library with Fontello for this exact reason, and the fact that I can't use my own icons is kind of a problem.

from ng2-table.

jeff-jacobs avatar jeff-jacobs commented on September 2, 2024 1

@Pokom Yeah, I ended up adding the fontawesome classes to my fontello icon list classes. It's kind of dirty, but it gets the job done for now. But yes, the real request is to have control over those classes/active states. Thanks :)

from ng2-table.

Pokom avatar Pokom commented on September 2, 2024

@jeffaxial
While this isn't an ideal solution, you can also just use the same classnames as the respective font-awesome icon and have those classes reference your set of icons. I think the true feature request is to have control to configure the icon classes for the table component, which would be ideal in your situation.

from ng2-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.