Make professor pages about rmc HOT 9 CLOSED

from rmc.

If they're not clear just from looking at, let me know and I can answer any questions. Similar layout to course pages, tweaked a bit for profs.

from rmc.

I'm probably misunderstanding something, but why are there two drawings? Does one transition into the other?

Will there be something to indicate which course a comment belongs to? It might even be a good idea to have a box (or a heading) for each course and their comments. I'm imagining something similar to the course page, where each professor is listed with their comments, except we would list courses instead.

A nice to have would be to have the side bar list all your friends who have been taught by this professor, similar to the course page for friends having taken the course.

Otherwise, looks great to me! Though I'm sure @divad12 will have much more feedback to give.

from rmc.

Sorry, two (slightly) different mockups! Thanks for the suggestions Sandy!

from rmc.

+1 clear divisions/groupings in reviews to clearly delineate which reviews belong to which course.

Yeah sidebar would definitely be nice to have, but can be done in a future PR.

I like that you've structured things to clearly re-use existing site components and styling (though of course don't feel constrained by that in mock-ups).

I definitely prefer your first mock-up with the sections that the professor taught, but getting that data is actually going to be a little tricky as @andyzg discovered — professor names that we get from the OpenData API (which comes from the registrar's website) uses full legal names, while the professor names from the reviews are from user input. What Andy did was apply a heuristic by hashing prof names using the function "{first initial}_{last name}" for linking section professors to professor reviews in a course page. That worked most of the time for course pages but is not going to work as well globally. I think there may be some Python similar-name matching libraries that you can use, but I would recommend actually leaving the sections table to another PR and limit the scope of this PR even more. Launch fast, ship small, and iterate.

Also, instead of "Past courses", why don't we just call it "All courses taught" and use our expandable course bars that we use on the profile page and the search page, to make it easy for anyone to get a brief summary of a course that a prof taught w/o navigating to another page. This also means you can ship this page w/o the "current term" section and still have it make sense.

from rmc.

Alright @divad12 here's another mockup, dead simple in design. Basically I show all the reviews for a prof, sorted by course. Features to add in later are to be able to scroll automatically to a certain course, use the searchbar, and leave a review for a prof on their page. For now, it'd just display reviews, organized by course.

Let me know what you think.

from rmc.

Kinda like this. I was also thinking about listing the courses taught by a prof, and when one of them is clicked then it will auto scroll down to the start of that section for the user.

from rmc.

Cool!

I think it would still be nice to somehow get the course descriptions in there by re-using CourseView, especially in the use case of "I really like this prof, I wonder what else s/he's taught and consider taking those courses too." CourseView gives us a view like this:

And you can configure it to show sections or text inputs for reviewing the course, as on the explore page.

What I think you could do is just show the first review (or just don't show any), and collapse all the rest of the reviews (which can be shown on click). This allows one to browse all the courses a professor has taught without endless scrolling, while still being able to read each review of each course. It also means you can completely drop a section — the index of courses taught. You don't really need it if you can easily see which courses a prof taught.

Does that make sense?

from rmc.

Good call on collapsing the courses! If I'm correct, there's already some code in there for that.

Also I like the idea of showing a bit about the course, I'll look into that as well. I'll post some more screenshots as I progress, to keep you in the loop.

from rmc.